From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80445C3815B for ; Mon, 20 Apr 2020 15:08:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4B1632074F for ; Mon, 20 Apr 2020 15:08:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B1632074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CEF608E0007; Mon, 20 Apr 2020 11:08:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C78B88E0003; Mon, 20 Apr 2020 11:08:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B19658E0007; Mon, 20 Apr 2020 11:08:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 99A308E0003 for ; Mon, 20 Apr 2020 11:08:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 451F1181AEF2A for ; Mon, 20 Apr 2020 15:08:23 +0000 (UTC) X-FDA: 76728564486.23.sheet00_2c176ea76cf0c X-HE-Tag: sheet00_2c176ea76cf0c X-Filterd-Recvd-Size: 3352 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 15:08:22 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id u127so10728059wmg.1 for ; Mon, 20 Apr 2020 08:08:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LNI93e5vPZH1Ixdr1aJv8yh1u9ouf7kkD98kfbExHb8=; b=k7zW29eAdTRPU0CwtQL5qv53RqCiUekpIaRoE72wfmpGZ5rdV4nrEkBwpzCCY85u92 W2u8xatI800qCweyOxTIL8BS2BcT4DWjjYg4YXCVMS4XmxnWSbGQqqWC8SSim5qS+bIe ztQ9dXGPJCpVpFAZXSzTkXPYcnELpG1EcA5a1OUG5j9hqzGVhJYOENfu2/OlYGXn/lIF NygeD63mabKZjabM8QMEzB6Xx0LLKLTGDVEf6JcZAFAqkB/WtZg60UR+9Q5zgKHpFtae Rnm0BKpdqgu/i24V1KwMsGsMZJIz96mrqp9OsUcFs1+xtOd/dnPGRP18Tf3kibjBPVJ5 nqjA== X-Gm-Message-State: AGi0PuYWN/QtrJVnTEKFxoxG4az39GfSfcccLG3EyIniVL0gesLwAEnL fB73LA5QxYE7UNDjQF08+G3Rt1Jm X-Google-Smtp-Source: APiQypIn0Cxsqg0GjxaLAKAupQQ/cKtQ5RmfKVyfSP1kCMa8Kpq6HK2MhTUtWovXO2DYYC9BOf7Ifw== X-Received: by 2002:a1c:23d4:: with SMTP id j203mr10008561wmj.49.1587395301942; Mon, 20 Apr 2020 08:08:21 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id u3sm1421023wrt.93.2020.04.20.08.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 08:08:21 -0700 (PDT) Date: Mon, 20 Apr 2020 17:08:20 +0200 From: Michal Hocko To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, willy@infradead.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH v2] mm/memory: remove unnecessary pte_devmap case in copy_one_pte() Message-ID: <20200420150820.GS27314@dhcp22.suse.cz> References: <1587349685-31712-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587349685-31712-1-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It would ve great to keep the cc list if reposting. On Mon 20-04-20 10:28:05, qiwuchen55@gmail.com wrote: > From: chenqiwu > > Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"), > the assignment to 'page' for pte_devmap case has been unnecessary. > Let's remove it. > And also [willy@infradead.org - changelog] > Signed-off-by: chenqiwu Acked-by: Michal Hocko > --- > Change in v2: > - According to Matthew's suggestion, update commit title and message. > mm/memory.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index f703fe8..2143827 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, > get_page(page); > page_dup_rmap(page, false); > rss[mm_counter(page)]++; > - } else if (pte_devmap(pte)) { > - page = pte_page(pte); > } > > out_set_pte: > -- > 1.9.1 > -- Michal Hocko SUSE Labs