From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C8CC3A5A0 for ; Mon, 20 Apr 2020 07:34:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B0C5214AF for ; Mon, 20 Apr 2020 07:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B0C5214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3CD18E0005; Mon, 20 Apr 2020 03:34:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC54F8E0003; Mon, 20 Apr 2020 03:34:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB45A8E0005; Mon, 20 Apr 2020 03:34:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 8F3EE8E0003 for ; Mon, 20 Apr 2020 03:34:38 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4616A2481 for ; Mon, 20 Apr 2020 07:34:38 +0000 (UTC) X-FDA: 76727421036.13.jump85_b5bfa8c3b957 X-HE-Tag: jump85_b5bfa8c3b957 X-Filterd-Recvd-Size: 3496 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 07:34:37 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id x18so10837894wrq.2 for ; Mon, 20 Apr 2020 00:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=J6rJMn+wy517qK6LezauDPAAdzw8pIiAhiJfakvu9RQ=; b=rEkb64dEtTkOmNHVr71ZZ7/VvU05Ro3cnRs8rR7i34z0W5ElZ/jhhVKFQ0tdUVInus WqAUnT0K0pcor3gg3jrzSOZ+DRImZwqZfAeVYJX/pG9v+Ny0uGJYDjMKnTHcpcGGEm0W i9rsbGFfiqP4brv0Rzc0BxFPsIVptY748wIxNUQrqe66zkgV6OI47kMrk74KcR2Mjsh3 sQtBlVJuZbZyzjZ1jKRc7ieRyNp4ghouAv9+hpodUozIzruNhurG9m36EolMCqT1TE2O NaAVhtlTAV4UQAvotKofe3i9pY34gxH6/jgvCDPkGo/qu8xo+nosCgkzgd8J7ru1tiNd NVtQ== X-Gm-Message-State: AGi0PuZCLkHpqgRgDLEzdzSc/gYfQb1HW+V1B4FTiNJpy2YIjvZfxaTq GI1KvqZp6wxhAWDj5EDKdHw= X-Google-Smtp-Source: APiQypLpNr3MZecJqP2+GqR3GqelU7seRMQZPFBobVF04nv7LWcIPzyQ5dbWLrvq1yrMMyhx2dsVpw== X-Received: by 2002:adf:ff89:: with SMTP id j9mr17118764wrr.245.1587368076910; Mon, 20 Apr 2020 00:34:36 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id v1sm41809wrv.19.2020.04.20.00.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 00:34:36 -0700 (PDT) Date: Mon, 20 Apr 2020 09:34:34 +0200 From: Michal Hocko To: Andrew Morton Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pavel Tatashin , Pankaj Gupta , Baoquan He , Shile Zhang , Kirill Tkhai , Daniel Jordan , Alexander Duyck , Oscar Salvador Subject: Re: [PATCH v2] mm/page_alloc: fix watchdog soft lockups during set_zone_contiguous() Message-ID: <20200420073434.GE27314@dhcp22.suse.cz> References: <20200416073417.5003-1-david@redhat.com> <20200417151247.0068d5aa3f026ced2289ce31@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417151247.0068d5aa3f026ced2289ce31@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 17-04-20 15:12:47, Andrew Morton wrote: > On Thu, 16 Apr 2020 09:34:17 +0200 David Hildenbrand wrote: > > > Without CONFIG_PREEMPT, it can happen that we get soft lockups detected, > > e.g., while booting up. > > > > ... > > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -1607,6 +1607,7 @@ void set_zone_contiguous(struct zone *zone) > > if (!__pageblock_pfn_to_page(block_start_pfn, > > block_end_pfn, zone)) > > return; > > + cond_resched(); > > } > > > > /* We confirm that there is no hole */ > > I added cc:stable to this one. Please let me know if that wasn't a > good idea. Really large memory setups tend to run on distribution kernels so backporting to old kernels doesn't really harm. -- Michal Hocko SUSE Labs