From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E315C38A30 for ; Sun, 19 Apr 2020 10:56:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD5C821974 for ; Sun, 19 Apr 2020 10:56:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="klZsaJBd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD5C821974 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63EC58E0005; Sun, 19 Apr 2020 06:56:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C7408E0003; Sun, 19 Apr 2020 06:56:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48F3B8E0005; Sun, 19 Apr 2020 06:56:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 2DDC28E0003 for ; Sun, 19 Apr 2020 06:56:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DE318180ACF9A for ; Sun, 19 Apr 2020 10:56:38 +0000 (UTC) X-FDA: 76724301276.15.look07_7401abc01de50 X-HE-Tag: look07_7401abc01de50 X-Filterd-Recvd-Size: 4398 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 10:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=87JQq/8fy/ba6TI5H7xOE4LoomBBm7ajqmEAFHP33Z8=; b=klZsaJBdjtnccxPkMYcYmx36Jg 2gxnROzkfj2g39w+iLyTtkAfTd+l79DKHZ+TUrLOPYgGk1uTdHZeb0bOwFCZZfOhp/rI5+T5CNIr0 QNTkudE1/FvokTmh10qQY7QabuyClkMR4fxn/yekdS8oyDk0qaBqzeM5ZT8NMPdS4+IRD3lsDZhDJ JDk5DcwYCG/+WtwEAk4MOezsrd8TOlP5MluJicOHCz41Ct/PoTyIJ99gRxkUPiyIlqfF76H95hmZN Y5XJaYufNd6eFtyalfDUmnGmeUxNqDiEVAO2A9a4i8s2bFHajB4yfYw1y/zdbyO0rOrwRqbOwWIjY BgvVcSZw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQ7cn-0006SZ-JM; Sun, 19 Apr 2020 10:56:33 +0000 Date: Sun, 19 Apr 2020 03:56:33 -0700 From: Matthew Wilcox To: Andrew Morton Cc: Randy Dunlap , broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Phillip Lougher , squashfs-devel@lists.sourceforge.net, Philippe Liard Subject: Re: mmotm 2020-04-17-20-35 uploaded (squashfs) Message-ID: <20200419105633.GX5820@bombadil.infradead.org> References: <20200418033629.oozqt8YrL%akpm@linux-foundation.org> <319997c2-5fc8-f889-2ea3-d913308a7c1f@infradead.org> <20200418124728.51632dbebc8b5dbc864cc34f@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200418124728.51632dbebc8b5dbc864cc34f@linux-foundation.org> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 18, 2020 at 12:47:28PM -0700, Andrew Morton wrote: > On Sat, 18 Apr 2020 08:56:31 -0700 Randy Dunlap = wrote: >=20 > > On 4/17/20 8:36 PM, akpm@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2020-04-17-20-35 has been uploaded to > > >=20 > > > http://www.ozlabs.org/~akpm/mmotm/ > > >=20 > > > mmotm-readme.txt says > > >=20 > > > README for mm-of-the-moment: > > >=20 > > > http://www.ozlabs.org/~akpm/mmotm/ > > >=20 > > > This is a snapshot of my -mm patch queue. Uploaded at random hopef= ully > > > more than once a week. > > >=20 > > > You will need quilt to apply these patches to the latest Linus rele= ase (5.x > > > or 5.x-rcY). The series file is in broken-out.tar.gz and is duplic= ated in > > > http://ozlabs.org/~akpm/mmotm/series > > >=20 > > > The file broken-out.tar.gz contains two datestamp files: .DATE and > > > .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-m= m-ss, > > > followed by the base kernel version against which this patch series= is to > > > be applied. > >=20 > > on x86_64: > >=20 > > CC fs/squashfs/decompressor_multi_percpu.o > > ../fs/squashfs/decompressor_multi_percpu.c:75:5: error: conflicting t= ypes for =E2=80=98squashfs_decompress=E2=80=99 > > int squashfs_decompress(struct squashfs_sb_info *msblk, struct buffe= r_head **bh, > > ^~~~~~~~~~~~~~~~~~~ >=20 > Thanks. Seems that file was missed. >=20 > Also, this code jumps through horrifying hoops in order to initialize > locals at their definition site. But the code looks so much better if > we Just Don't Do That! I think the code would look even better if things just Had The Right Type= ! struct squashfs_sb_info { ... - struct squashfs_stream *stream; + union { + struct squashfs_stream *stream; + struct squashfs_stream __percpu *percpu_stream; + }; int squashfs_decompress(struct squashfs_sb_info *msblk, struct bio *bio, int offset, int length, struct squashfs_page_actor *output) { struct squashfs_stream *stream =3D get_cpu_ptr(msblk->percpu_stream); int res =3D msblk->decompressor->decompress(msblk, stream->stream, bh, b= , offset, length, output); ... As an aside, that calling convention could do with putting some of the arguments into a struct so the CPU spends less time shuffling arguments from one register to another.