From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF4ADC38A30 for ; Sun, 19 Apr 2020 10:30:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A94EE2080C for ; Sun, 19 Apr 2020 10:30:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bdxCYYCH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A94EE2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4560B8E0005; Sun, 19 Apr 2020 06:30:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 406958E0003; Sun, 19 Apr 2020 06:30:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31C488E0005; Sun, 19 Apr 2020 06:30:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id 171DD8E0003 for ; Sun, 19 Apr 2020 06:30:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C011A181AEF31 for ; Sun, 19 Apr 2020 10:30:45 +0000 (UTC) X-FDA: 76724236050.08.magic85_23b96d299c20b X-HE-Tag: magic85_23b96d299c20b X-Filterd-Recvd-Size: 2083 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 10:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JFQAtZu+slNtUWz7cS9/BiHm2WjDv1XTdtGgbjbXj90=; b=bdxCYYCHpXm1vhdkxw0xlDL6z8 3OYLD+qsQbbUHSxHZTJT/JzR8wFGj8SkebjgHGHNQq8+RFvW+RbgYRLHbGPfeMUevrOfOFZ4w7kJF hWgJxTAYmFiGf7YSNb5ZRNERSJ684kCAhL8wT8/Dja3yUjqgDU6OVckRKTT6kne7cs86ilXnEGUOa IQcyRGOxOdgGxA6E75tNSTyBZ1r86QOWsSDYoei43+KRwv6YnLQmyX6YlOVoqOk5eGskiFMwQmoGS fPB0hBu00Qsct6aeFB/KRDAQXeZC2WC/L3JZjQFDVOCdvCL+VeGvwgBLGe9RSt5xPGwoef9pAVXt9 SXXmJnXQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQ7Di-000844-Jj; Sun, 19 Apr 2020 10:30:38 +0000 Date: Sun, 19 Apr 2020 03:30:38 -0700 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH 2/2] mm/memory: put refcount of normal page in zap_pte_range() Message-ID: <20200419103038.GW5820@bombadil.infradead.org> References: <1587267017-25310-1-git-send-email-qiwuchen55@gmail.com> <1587267017-25310-2-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587267017-25310-2-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 19, 2020 at 11:30:17AM +0800, qiwuchen55@gmail.com wrote: > From: chenqiwu > > As discussed in patch[1], there is an imbalnace of normal > page refcount between copy_one_pte() and zap_pte_range(). > This patch put the refcount of normal page back in > zap_pte_range() to fix the imbalance. I think you misunderstood the discussion. NAK. Did you test this?