linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: qiwuchen55@gmail.com
Cc: akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org,
	chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH 2/2] mm/memory: put refcount of normal page in zap_pte_range()
Date: Sun, 19 Apr 2020 03:30:38 -0700	[thread overview]
Message-ID: <20200419103038.GW5820@bombadil.infradead.org> (raw)
In-Reply-To: <1587267017-25310-2-git-send-email-qiwuchen55@gmail.com>

On Sun, Apr 19, 2020 at 11:30:17AM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> As discussed in patch[1], there is an imbalnace of normal
> page refcount between copy_one_pte() and zap_pte_range().
> This patch put the refcount of normal page back in
> zap_pte_range() to fix the imbalance.

I think you misunderstood the discussion.  NAK.  Did you test this?


  reply	other threads:[~2020-04-19 10:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19  3:30 [PATCH 1/2] mm/memory: remove redundant pte_devmap case for copy_one_pte() qiwuchen55
2020-04-19  3:30 ` [PATCH 2/2] mm/memory: put refcount of normal page in zap_pte_range() qiwuchen55
2020-04-19 10:30   ` Matthew Wilcox [this message]
2020-04-19 10:26 ` [PATCH 1/2] mm/memory: remove redundant pte_devmap case for copy_one_pte() Matthew Wilcox
2020-04-20  7:54   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200419103038.GW5820@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=chenqiwu@xiaomi.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=qiwuchen55@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox