From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7C5C38A30 for ; Sun, 19 Apr 2020 10:26:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C4A1214AF for ; Sun, 19 Apr 2020 10:26:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lUOxflJ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C4A1214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DF78E8E0005; Sun, 19 Apr 2020 06:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA6588E0003; Sun, 19 Apr 2020 06:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C95E88E0005; Sun, 19 Apr 2020 06:26:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id B0A358E0003 for ; Sun, 19 Apr 2020 06:26:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 641A752DA for ; Sun, 19 Apr 2020 10:26:22 +0000 (UTC) X-FDA: 76724225004.21.ring14_8e7a6c22dac23 X-HE-Tag: ring14_8e7a6c22dac23 X-Filterd-Recvd-Size: 2793 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 10:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2CLYAk4v3ifv+ABdblmVHOld1NQS4igew9gROMZik2I=; b=lUOxflJ4wi7eMPUlxUXF2/yrOs iXzQsKVP2ifbGNj8smysTO69BYqnj+qCSZlZNJXHI+Wvi4VthhjhARxm6hFEofFdJx/8nl6tEEfU9 o532EhQ4Xj4rbscUVQZ2XrEYy2FPZ85E4pVZ5IiZeHE2cbAykLCLI1k41qS1n0WgpI4uUVWmcuamj WtU8V+geoMxvyE8AtaA7nrj44RrVEjWP5grh33nRiGLhF7jRh84zWVabfv2OzDo41B8lCwNeb3hlW oZHDqujKtZU0IVfRqXKlb7qykywM3CD4frSTa2lrdRpkCpLm5hz1zJVZC7MuAH9OYYSWQwM6jkVq9 iOaeJ0Og==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQ79R-0005Rb-QD; Sun, 19 Apr 2020 10:26:13 +0000 Date: Sun, 19 Apr 2020 03:26:13 -0700 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, mhocko@suse.com, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH 1/2] mm/memory: remove redundant pte_devmap case for copy_one_pte() Message-ID: <20200419102613.GV5820@bombadil.infradead.org> References: <1587267017-25310-1-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587267017-25310-1-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 19, 2020 at 11:30:16AM +0800, qiwuchen55@gmail.com wrote: > From: chenqiwu > > As discussed in patch[1], special mapping ptes such as device > mapping ptes don't need to operate on their corresponding pages, > so the redundant pte_devmap case can be removed. > > [1] https://patchwork.kernel.org/patch/11494691/ This is a terrible changelog. What it should say is something like: Since commit 25b2995a35b6 ("mm: remove MEMORY_DEVICE_PUBLIC support"), the assignment to 'page' has been unnecessary. Remove it. Reviewed-by: Matthew Wilcox (Oracle) > Signed-off-by: chenqiwu > --- > mm/memory.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index f703fe8..2143827 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -802,8 +802,6 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, > get_page(page); > page_dup_rmap(page, false); > rss[mm_counter(page)]++; > - } else if (pte_devmap(pte)) { > - page = pte_page(pte); > } > > out_set_pte: > -- > 1.9.1 > >