From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F1CC38A29 for ; Fri, 17 Apr 2020 22:12:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9365B2137B for ; Fri, 17 Apr 2020 22:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="CDWhqyB/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9365B2137B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 253818E0003; Fri, 17 Apr 2020 18:12:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2049A8E0001; Fri, 17 Apr 2020 18:12:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A228E0003; Fri, 17 Apr 2020 18:12:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id EBE598E0001 for ; Fri, 17 Apr 2020 18:12:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9CE47181AEF21 for ; Fri, 17 Apr 2020 22:12:49 +0000 (UTC) X-FDA: 76718747658.19.oil01_52d9cecc34257 X-HE-Tag: oil01_52d9cecc34257 X-Filterd-Recvd-Size: 2482 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Apr 2020 22:12:49 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC87120B1F; Fri, 17 Apr 2020 22:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587161568; bh=ON4JdnnSp41GHtVfQ1OKELVDXoHAdZJmnEWPX+XFdCw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CDWhqyB/IlZyphu6jsbA1XfIALDH+nOe4HMk0CDTKJ7edRKniwEH2Cq+6D/wK2Gtl LEi7bg2GM4iBlFWRMCs4hLDij8zeCyTpVgDxl8AmR4nH1dTgIso263RiE9OJ6J4j6z gAz6SYiK4GGU1A0Frqsr7AiKouEeUxj1Au0TBSAk= Date: Fri, 17 Apr 2020 15:12:47 -0700 From: Andrew Morton To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pavel Tatashin , Pankaj Gupta , Baoquan He , Shile Zhang , Michal Hocko , Kirill Tkhai , Daniel Jordan , Michal Hocko , Alexander Duyck , Oscar Salvador Subject: Re: [PATCH v2] mm/page_alloc: fix watchdog soft lockups during set_zone_contiguous() Message-Id: <20200417151247.0068d5aa3f026ced2289ce31@linux-foundation.org> In-Reply-To: <20200416073417.5003-1-david@redhat.com> References: <20200416073417.5003-1-david@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Apr 2020 09:34:17 +0200 David Hildenbrand wrote: > Without CONFIG_PREEMPT, it can happen that we get soft lockups detected, > e.g., while booting up. > > ... > > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1607,6 +1607,7 @@ void set_zone_contiguous(struct zone *zone) > if (!__pageblock_pfn_to_page(block_start_pfn, > block_end_pfn, zone)) > return; > + cond_resched(); > } > > /* We confirm that there is no hole */ I added cc:stable to this one. Please let me know if that wasn't a good idea.