From: Andrew Morton <akpm@linux-foundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Baoquan He <bhe@redhat.com>,
Shile Zhang <shile.zhang@linux.alibaba.com>,
Michal Hocko <mhocko@suse.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Michal Hocko <mhocko@kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v2] mm/page_alloc: fix watchdog soft lockups during set_zone_contiguous()
Date: Fri, 17 Apr 2020 15:12:47 -0700 [thread overview]
Message-ID: <20200417151247.0068d5aa3f026ced2289ce31@linux-foundation.org> (raw)
In-Reply-To: <20200416073417.5003-1-david@redhat.com>
On Thu, 16 Apr 2020 09:34:17 +0200 David Hildenbrand <david@redhat.com> wrote:
> Without CONFIG_PREEMPT, it can happen that we get soft lockups detected,
> e.g., while booting up.
>
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1607,6 +1607,7 @@ void set_zone_contiguous(struct zone *zone)
> if (!__pageblock_pfn_to_page(block_start_pfn,
> block_end_pfn, zone))
> return;
> + cond_resched();
> }
>
> /* We confirm that there is no hole */
I added cc:stable to this one. Please let me know if that wasn't a
good idea.
next prev parent reply other threads:[~2020-04-17 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 7:34 David Hildenbrand
2020-04-17 22:12 ` Andrew Morton [this message]
2020-04-20 7:34 ` Michal Hocko
2020-04-20 7:42 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417151247.0068d5aa3f026ced2289ce31@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=bhe@redhat.com \
--cc=daniel.m.jordan@oracle.com \
--cc=david@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=shile.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox