From: Andrew Morton <akpm@linux-foundation.org>
To: "Huang\, Ying" <ying.huang@intel.com>
Cc: Andrea Righi <andrea.righi@canonical.com>,
Minchan Kim <minchan@kernel.org>,
Anchal Agarwal <anchalag@amazon.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm: swap: properly update readahead statistics in unuse_pte_range()
Date: Thu, 16 Apr 2020 21:06:46 -0700 [thread overview]
Message-ID: <20200416210646.774bae8c321e3a44d6ffa8c3@linux-foundation.org> (raw)
In-Reply-To: <871romvmrh.fsf@yhuang-dev.intel.com>
On Fri, 17 Apr 2020 11:01:22 +0800 "Huang\, Ying" <ying.huang@intel.com> wrote:
> Andrea Righi <andrea.righi@canonical.com> writes:
>
> > In unuse_pte_range() we blindly swap-in pages without checking if the
> > swap entry is already present in the swap cache.
> >
> > By doing this, the hit/miss ratio used by the swap readahead heuristic
> > is not properly updated and this leads to non-optimal performance during
> > swapoff.
>
> It's more important to describe why we need this patch in the patch
> description. So, please add some information about your use case. And
> please focus on the technical part instead of the business part.
Confused. I thought the changelog was quite good. If "business part"
means "end user effect of the patch" then that's a very important
thing.
> Thanks! But you don't need to do this. You can add my Reviewed-by after
> we have finished the work on patch description.
Can you be more specific about how you want this changed?
next prev parent reply other threads:[~2020-04-17 4:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 18:01 Andrea Righi
2020-04-17 3:01 ` Huang, Ying
2020-04-17 4:06 ` Andrew Morton [this message]
2020-04-17 5:18 ` Huang, Ying
2020-04-18 8:51 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416210646.774bae8c321e3a44d6ffa8c3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=anchalag@amazon.com \
--cc=andrea.righi@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox