From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41654C352BE for ; Thu, 16 Apr 2020 15:53:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 112C320656 for ; Thu, 16 Apr 2020 15:53:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 112C320656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A40DC8E00C3; Thu, 16 Apr 2020 11:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CB2C8E00BC; Thu, 16 Apr 2020 11:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8916D8E00C3; Thu, 16 Apr 2020 11:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 6DAFB8E00BC for ; Thu, 16 Apr 2020 11:53:31 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2F2E4824556B for ; Thu, 16 Apr 2020 15:53:31 +0000 (UTC) X-FDA: 76714163022.21.scarf34_3bc34be1f2328 X-HE-Tag: scarf34_3bc34be1f2328 X-Filterd-Recvd-Size: 5818 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Apr 2020 15:53:30 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id 188so1806731pgj.13 for ; Thu, 16 Apr 2020 08:53:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OJ1LhAU7febKN7iQIuormh5NmKS7oObKFw3LJa4CTas=; b=JeXIirZlA4uZrPZt+zkiUOhDk8PCHWLvhwRhrVdISuICIm1CzRWFtB+Tb0+o+Brzc7 eJqjilsAC/+Y0KlRy5JCk1+NyLqrnMAbab1ImRRbohlufax9oh91Xe17uYT5zb9w4g77 XsbUe/jqLdyBnn+2g7FMQocYCI83uhBbQiLA00ZOCHZg7M1mPfgWRSTJZM5rRFb8tU++ Pk/Uav33kKar6+5Mg9rZNrl9K2SM+N6XxjEwmRDk1+gRYV6LkcDXEp/txBAQ3ZJfTrYP iOTy6ewXFh6fbO7iof02L7HO3fr79znq7h6PMXQ5rGmfYBOj4iwvG4vCndeiqUNkNGT9 P0sA== X-Gm-Message-State: AGi0PuZEf/k1nwl6qK/yP10LcywNfOQ/T38kvtv+uXkCp6mSjR862d+6 /N++PA1NPY4TrLVXI4U7W6w= X-Google-Smtp-Source: APiQypL0bCBep50MvO+I1irfI6M146DVq6XZM9/sttMzKb5K92PS7O9TaiV4Z2X9iDlZuALlgjDLLQ== X-Received: by 2002:a63:894a:: with SMTP id v71mr33642388pgd.314.1587052409606; Thu, 16 Apr 2020 08:53:29 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o15sm15680232pgj.60.2020.04.16.08.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 08:53:28 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 9C1A440277; Thu, 16 Apr 2020 15:53:27 +0000 (UTC) Date: Thu, 16 Apr 2020 15:53:27 +0000 From: Luis Chamberlain To: Masami Hiramatsu Cc: Vlastimil Babka , Andrew Morton , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH v2 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <20200416155327.GT11244@42.do-not-panic.com> References: <20200414113222.16959-1-vbabka@suse.cz> <20200414113222.16959-2-vbabka@suse.cz> <20200415180355.00bc828ea726c421638db871@kernel.org> <20200416012931.GE11244@42.do-not-panic.com> <20200416194955.3448c8526ea3f59e95c506da@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416194955.3448c8526ea3f59e95c506da@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 16, 2020 at 07:49:55PM +0900, Masami Hiramatsu wrote: > Hi Luis, > > On Thu, 16 Apr 2020 01:29:31 +0000 > Luis Chamberlain wrote: > > > On Wed, Apr 15, 2020 at 06:03:55PM +0900, Masami Hiramatsu wrote: > > > On Tue, 14 Apr 2020 13:32:20 +0200 > > > Vlastimil Babka wrote: > > > > diff --git a/init/main.c b/init/main.c > > > > index a48617f2e5e5..7b43118215d6 100644 > > > > --- a/init/main.c > > > > +++ b/init/main.c > > > > @@ -1372,6 +1372,8 @@ static int __ref kernel_init(void *unused) > > > > > > > > rcu_end_inkernel_boot(); > > > > > > > > + do_sysctl_args(); > > > > + > > > > > > Ah, I see. Since the sysctl is designed to be called after all __init calls were > > > done, it shouldn't use bootconfig directly because bootconfig is full of __init > > > call. > > > > The idea is bootconfig would be useful in the sense of a library set of > > helpers which could be modified to remove __init, and then used to > > instrument the cmdline depending on certain debugging kconfig entries. > > Would you mean making bootconfig (parser and APIs) be more generic so that > other subsystem can reuse it with their data? > Or just make it available after boot? (I think this latter one will be > useful for module initialization) The later. First use case that comes to mind is debugging cmdline, so to see if what one adds is what ends up happening at run time after boot. > > We currently have no way to purposely extend / break the cmdline for > > debugging purposes, so, bootconfig's parsers, since it already has a > > way to extend the cmdlineline, might make it much easier to do this > > later. > > > > Without bootconfig, if we wanted to add new kconfig to, for example, > > add new funny cmdline arguments to test they worked or not, we'd have > > to devise our own set of helpers now. ie, new functionality. bootconfig > > however already has existing functionality to tweak the cmdline, and so > > some code could be leveraged there for this purpose. > > Hmm, you can use the bootconfig as a "supplemental" kernel command line, > but not tweak (like modify/replace) it. Would you like to change the > kernel command line parameter on-line? It would be during boot. To augment it as if the user had used certain parameters on boot. But if only a new path is tested, and we can't reproduce as if the user had *not* used bootconfig, this idea would only be useful to test bootconfig parsing, nothing else. The hope was to do both. Luis