From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA47BC2BA19 for ; Wed, 15 Apr 2020 23:04:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C16320774 for ; Wed, 15 Apr 2020 23:04:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zL+Lb3Se" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C16320774 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E7058E0053; Wed, 15 Apr 2020 19:04:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 397608E0001; Wed, 15 Apr 2020 19:04:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2ACFF8E0053; Wed, 15 Apr 2020 19:04:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 10CC18E0001 for ; Wed, 15 Apr 2020 19:04:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B2D762C88 for ; Wed, 15 Apr 2020 23:04:41 +0000 (UTC) X-FDA: 76711620762.04.mind08_803f80808d218 X-HE-Tag: mind08_803f80808d218 X-Filterd-Recvd-Size: 2088 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 23:04:41 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FC6F20768; Wed, 15 Apr 2020 23:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586991880; bh=55qAwhO0WzZi7LtNMraWynM8BWS2Jzp4KBDWiaLriyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zL+Lb3SetfXpJ1/3b5i2NIrMtw3EomzLT2OldikQWOTfL9K+64V4uQEvlC6G0GNRi ya1Iu/dc5hdW0Z5y0tTCBJyw2xUHQf8ov+8RobpU+ii90Q177oZSGZZfjonjfTVZA/ iw+EvQqes52ioJy350hn9Yx4b4cQNcnfuXN0tqIg= Date: Wed, 15 Apr 2020 16:04:39 -0700 From: Andrew Morton To: Zou Wei Cc: , Subject: Re: [PATCH -next] mm/usercopy: fix warning Comparison to bool Message-Id: <20200415160439.256c89d4cb67b76d4119935d@linux-foundation.org> In-Reply-To: <1586835724-45738-1-git-send-email-zou_wei@huawei.com> References: <1586835724-45738-1-git-send-email-zou_wei@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Apr 2020 11:42:04 +0800 Zou Wei wrote: > fix below warnings reported by coccicheck > > mm/usercopy.c:304:5-18: WARNING: Comparison to bool > > ... > > --- a/mm/usercopy.c > +++ b/mm/usercopy.c > @@ -301,7 +301,7 @@ __setup("hardened_usercopy=", parse_hardened_usercopy); > > static int __init set_hardened_usercopy(void) > { > - if (enable_checks == false) > + if (!enable_checks) > static_branch_enable(&bypass_usercopy_checks); > return 1; > } My initial reaction is "fix coccicheck". There's nothing wrong with that code?