From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0899FC352BE for ; Wed, 15 Apr 2020 03:23:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCB5C2083B for ; Wed, 15 Apr 2020 03:23:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0K6+eu09" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCB5C2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5601B8E0007; Tue, 14 Apr 2020 23:23:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E99B8E0001; Tue, 14 Apr 2020 23:23:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 389C08E0007; Tue, 14 Apr 2020 23:23:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 1E07B8E0001 for ; Tue, 14 Apr 2020 23:23:29 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D9AC8180AD801 for ; Wed, 15 Apr 2020 03:23:28 +0000 (UTC) X-FDA: 76708644096.06.sink84_13cd3c02e043 X-HE-Tag: sink84_13cd3c02e043 X-Filterd-Recvd-Size: 3957 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Apr 2020 03:23:28 +0000 (UTC) Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4E902076C; Wed, 15 Apr 2020 03:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586921007; bh=E+A8GbmRdkiChcOTscbAJQjnd5pGOJMNuDZNPxk7gQI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0K6+eu09mA4b4Wx8yvMa9i30yk8a4a1FWzBnikHTYAuTjvN9GNyB+1uNW4FFziyrc Jw7OYfxnTK0ZEPbPSRcTyCp2gZkbQVh46FTxNtmcoQbnaNGpHzZHmU60FBJv4TSaYf lANGZhUhbaY2ogdN5qlLEFGKQ/OTJZvBk1gNx8P8= Date: Wed, 15 Apr 2020 12:23:20 +0900 From: Masami Hiramatsu To: Vlastimil Babka Cc: Luis Chamberlain , Kees Cook , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner , Masami Hiramatsu Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-Id: <20200415122320.70668776379706323bbc752e@kernel.org> In-Reply-To: <7585f0b0-c5d2-b527-aac7-eeafdd15ffad@suse.cz> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> <20200330224422.GX11244@42.do-not-panic.com> <287ac6ae-a898-3e68-c7d8-4c1d17a40db9@suse.cz> <20200402160442.GA11244@42.do-not-panic.com> <202004021017.3A23B759@keescook> <20200402205932.GM11244@42.do-not-panic.com> <202004031654.C4389A04EF@keescook> <20200406140836.GA11244@42.do-not-panic.com> <202004060856.6BC17C5C99@keescook> <20200406170822.GE11244@42.do-not-panic.com> <7585f0b0-c5d2-b527-aac7-eeafdd15ffad@suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Apr 2020 13:25:07 +0200 Vlastimil Babka wrote: > On 4/6/20 7:08 PM, Luis Chamberlain wrote: > > On Mon, Apr 06, 2020 at 08:58:50AM -0700, Kees Cook wrote: > >> On Mon, Apr 06, 2020 at 02:08:36PM +0000, Luis Chamberlain wrote: > >> > > Yes. Doing an internal extension isn't testing the actual code. > >> > > >> > But it would. > >> > > >> > [...] > >> > > I don't think anything is needed for this series. It can be boot tested > >> > > manually. > >> > > >> > Why test it manually when it could be tested automatically with a new kconfig? > >> > >> So, my impression is that adding code to the internals to test the > >> internals isn't a valid test (or at least makes it fragile) because the > >> test would depend on the changes to the internals (or at least depend on > >> non-default non-production CONFIGs). > > > > The *internal* aspect here is an extension to boot params under a > > kconfig which would simply append to it, as if the user would have > > So there's no such kconfig yet to apply boot parameters specified by configure, > right? That would itself be a new feature. Or could we use bootconfig? (CC Masami) Yes, I think you can use bootconfig to add this feature more flexibly. I think your patch is easily modified to use bootconfig. :) Thank you, -- Masami Hiramatsu