From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA46C2BA19 for ; Tue, 14 Apr 2020 11:37:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE876206D5 for ; Tue, 14 Apr 2020 11:37:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE876206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6EE538E0005; Tue, 14 Apr 2020 07:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69E048E0001; Tue, 14 Apr 2020 07:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B4058E0005; Tue, 14 Apr 2020 07:37:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 416338E0001 for ; Tue, 14 Apr 2020 07:37:33 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EF562181AEF0B for ; Tue, 14 Apr 2020 11:37:32 +0000 (UTC) X-FDA: 76706260344.08.cows78_24c7234bfcb4a X-HE-Tag: cows78_24c7234bfcb4a X-Filterd-Recvd-Size: 3986 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 11:37:32 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id o81so7031918wmo.2 for ; Tue, 14 Apr 2020 04:37:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sZ8CX2OLj8e4jBkaM6apCXhxUob9hd2xQu1TNFcfLjY=; b=oPvrFYfYtSdVXKzCuwEPxVCMQbisGTm9SJVSQv+qjn+8t198nnmm+nbgc71XuxbezA NyP2kQNJMYIvYiEWYsKKD1ExnXrog4gSdrdEzmD0ZMXiYwqtfThDVshekMPm83n70p6j PnWCljrexlriHRXl7beSkBTu28uuJ0srICwadEcK5zu72Vl8cVoXQcGSt6u4FllXudNz 0nUjJKwT4x4DG3eXbytHj1NYdZ1hvkNv5P+eYfCGjnj4lKm1PgL3WEGp+subuy5IGdpk wFOIRqFuqD21yP8r9Qqi5fvHqXHech328B1E9aAeFRQgAWCrn6sQJJK5wdPmOQBKaGrB IijQ== X-Gm-Message-State: AGi0Pubg/an3xby1RY8zGd0k+UrxPpJEs5qDx48/ON3Sv5HGY54VzTj/ BJCCWq+Ro1YJIO1H5SUkcTU= X-Google-Smtp-Source: APiQypLVb+QMixbBMaPAk6mNsPKP6B2IbHo4Bav7bhCSERvXdMMCTam9iO5LIxr/Zefb/9WRU9dfMA== X-Received: by 2002:a1c:e1c1:: with SMTP id y184mr23860084wmg.143.1586864251539; Tue, 14 Apr 2020 04:37:31 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id p6sm11348533wrt.3.2020.04.14.04.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 04:37:30 -0700 (PDT) Date: Tue, 14 Apr 2020 13:37:30 +0200 From: Michal Hocko To: svc_lmoiseichuk@magicleap.com Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, akpm@linux-foundation.org, rientjes@google.com, minchan@kernel.org, vinmenon@codeaurora.org, andriy.shevchenko@linux.intel.com, anton.vorontsov@linaro.org, penberg@kernel.org, linux-mm@kvack.org, Leonid Moiseichuk Subject: Re: [PATCH 0/2] memcg, vmpressure: expose vmpressure controls Message-ID: <20200414113730.GH4629@dhcp22.suse.cz> References: <20200413215750.7239-1-lmoiseichuk@magicleap.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413215750.7239-1-lmoiseichuk@magicleap.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 13-04-20 17:57:48, svc_lmoiseichuk@magicleap.com wrote: > From: Leonid Moiseichuk > > Small tweak to populate vmpressure parameters to userspace without > any built-in logic change. > > The vmpressure is used actively (e.g. on Android) to track mm stress. > vmpressure parameters selected empiricaly quite long time ago and not > always suitable for modern memory configurations. This needs much more details. Why it is not suitable? What are usual numbers you need to set up to work properly? Why those wouldn't be generally applicable? Anyway, I have to confess I am not a big fan of this. vmpressure turned out to be a very weak interface to measure the memory pressure. Not only it is not numa aware which makes it unusable on many systems it also gives data way too late from the practice. Btw. why don't you use /proc/pressure/memory resp. its memcg counterpart to measure the memory pressure in the first place? > Leonid Moiseichuk (2): > memcg: expose vmpressure knobs > memcg, vmpressure: expose vmpressure controls > > .../admin-guide/cgroup-v1/memory.rst | 12 +- > include/linux/vmpressure.h | 35 ++++++ > mm/memcontrol.c | 113 ++++++++++++++++++ > mm/vmpressure.c | 101 +++++++--------- > 4 files changed, 200 insertions(+), 61 deletions(-) > > -- > 2.17.1 > -- Michal Hocko SUSE Labs