From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E13C2D0EC for ; Sun, 12 Apr 2020 21:42:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 493E3206C3 for ; Sun, 12 Apr 2020 21:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LNm4BZzT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 493E3206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8C7A8E00EE; Sun, 12 Apr 2020 17:42:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3A2D8E00D0; Sun, 12 Apr 2020 17:42:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9292C8E00EE; Sun, 12 Apr 2020 17:42:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 7F1E78E00D0 for ; Sun, 12 Apr 2020 17:42:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 343AF180AD801 for ; Sun, 12 Apr 2020 21:42:03 +0000 (UTC) X-FDA: 76700526126.16.actor21_692a530096d22 X-HE-Tag: actor21_692a530096d22 X-Filterd-Recvd-Size: 6349 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Sun, 12 Apr 2020 21:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586727722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ntL02ndx4eQAgQinJMTsMk0remsmgxVljkSofSCs4LE=; b=LNm4BZzT3L0ZVWXJ+9kp4wTlMGI5jx1dRmEBrURowRf+eeNV8sutq0SQe6yvQ+YZ1R0Cp7 vPGw9RC6MRFDwtbFlEh55Ap3o7W3qu9Pdl5Ne4975brj8or6DgaMu01WqgGwb0ToJFGqHX LwDfv0YiNA7bHmc7MU7qBlVmEUaiY7s= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-CzDcAYSFPzmqWr1jLlEUGw-1; Sun, 12 Apr 2020 17:41:55 -0400 X-MC-Unique: CzDcAYSFPzmqWr1jLlEUGw-1 Received: by mail-qt1-f198.google.com with SMTP id x56so7362633qtc.10 for ; Sun, 12 Apr 2020 14:41:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cZgZS3VL9u0IfZZxKaJedf/PTKndLbqxtt6EqiRUq98=; b=jTv/A5yjkdN54BwkikS5sKj2EJb+cbkAZfl3ICch6HGBbrBid1t82h9hoYhYXsY26J cANMRAUCBNeLL3IZEDHEDe5bMIST2kBYwIVSM3t6N8Z+5qRrwawmxvAftExRLAqH83zO uWXBZEDBBLDXdjfOf2sClgl9hmAyiIU5UV+DaFmhG25ENvMQwbMFPMKwcBif0kRKHepP p+1g8ZVItp478gC8iJL9OkkLeELRw4ualEzW1NCzttlL5KR77Jx9jo1nPekXlYjGDa1X K4ltTyMrxk4DU6ILGHZ8lq3Vj5cODSEflkn3mYdOyR66f2JzWnIudYT1G+FPtZuOO/3B 4fAA== X-Gm-Message-State: AGi0PuY/VgAN8tUD2OAUJaiL8KMTzMVSGWS5PPWcHiSoDrbI2o5A6kSH 7mWTzfCkNUacw4wzK1byc63yNL5i5vYaok079HeCWgbPh9o8U91Kkq95Hj/J9GDsVHNziUskSx3 PoXm3WYpkb08= X-Received: by 2002:ac8:7408:: with SMTP id p8mr8849262qtq.82.1586727714586; Sun, 12 Apr 2020 14:41:54 -0700 (PDT) X-Google-Smtp-Source: APiQypLYhh5/2KJDBWWaSqKpz9rNtf6twGnt8bcq4F1iR6WS2PijfIjU2a+iOx4m4OwZ4jGuWFBpvg== X-Received: by 2002:ac8:7408:: with SMTP id p8mr8849243qtq.82.1586727714223; Sun, 12 Apr 2020 14:41:54 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id j92sm1505197qtd.58.2020.04.12.14.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2020 14:41:53 -0700 (PDT) Date: Sun, 12 Apr 2020 17:41:50 -0400 From: Peter Xu To: Naresh Kamboju Cc: open list , "open list:KERNEL SELFTEST FRAMEWORK" , linux-mm , lkft-triage@lists.linaro.org, Shuah Khan , Anders Roxell , Christophe Leroy , Andrew Morton , Leonardo Bras , Michael Ellerman , Mike Rapoport , Arnd Bergmann , Jules Irenge , "Huang, Ying" , Pankaj Gupta , Rik van Riel , Hugh Dickins , Minchan Kim , Mel Gorman , Dave Hansen , Mateusz Nosek , Sebastian Andrzej Siewior , Kees Cook , Vlastimil Babka , Hillf Danton Subject: Re: i386: selftests: vm: compaction_test: BUG: kernel NULL pointer dereference, address: 00000000 Message-ID: <20200412214150.GB38470@xz-x1> References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Naresh, On Sun, Apr 12, 2020 at 12:24:57PM +0530, Naresh Kamboju wrote: > On Linux mainline kernel 5.6.0 running kselftest vm compaction_test on i3= 86 > kernel running on x86_64 devices we have noticed this Kernel BUG followe= d by > Kernel panic. >=20 > BUG: kernel NULL pointer dereference, address: 00000000 > Kernel panic - not syncing: Attempted to kill init! exitcode=3D0x00000009 >=20 > Steps to reproduce: > -------------------------- > # cd /opt/kselftests/default-in-kernel/vm/ > # ./compaction_test >=20 > [ 45.955706] kauditd_printk_skb: 15 callbacks suppressed > [ 45.955707] audit: type=3D1334 audit(1586671685.974:25): prog-id=3D13 = op=3DUNLOAD > [ 45.968082] audit: type=3D1334 audit(1586671685.974:26): prog-id=3D12 = op=3DUNLOAD > [ 46.008163] get_swap_device: Bad swap file entry 7007504a > [ 46.013647] BUG: kernel NULL pointer dereference, address: 00000000 I suspect this is the same issue with: https://lore.kernel.org/lkml/20200410002518.GG8179@shao2-debian/ And since this one is very easy to reproduce, I finally noticed that we have wrongly enabled uffd-wp on x86_32, which is definely not going to work... Because we'll use bit 2 of swap entry assuming that's the uffd-wp bit, while that's part of swp offset on 32bit systems. Naresh, could you try whether below change fixes the issue for you? diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 8d078642b4be..7ac524d1316e 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -149,7 +149,7 @@ config X86 select HAVE_ARCH_TRACEHOOK select HAVE_ARCH_TRANSPARENT_HUGEPAGE select HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD if X86_64 - select HAVE_ARCH_USERFAULTFD_WP if USERFAULTFD + select HAVE_ARCH_USERFAULTFD_WP if X86_64 && USERFAULTFD select HAVE_ARCH_VMAP_STACK if X86_64 select HAVE_ARCH_WITHIN_STACK_FRAMES select HAVE_ASM_MODVERSIONS Thanks, --=20 Peter Xu