* [RFC PATCH 6/9] mm: export-GPL get_pageblock_migratetype [not found] <20200409193543.18115-1-mathieu.desnoyers@efficios.com> @ 2020-04-09 19:35 ` Mathieu Desnoyers 2020-04-12 8:14 ` Christoph Hellwig 0 siblings, 1 reply; 2+ messages in thread From: Mathieu Desnoyers @ 2020-04-09 19:35 UTC (permalink / raw) To: Thomas Gleixner, Will Deacon, akpm, Greg Kroah-Hartman, K . Prasad, Masami Hiramatsu, rostedt, Alexei Starovoitov Cc: linux-kernel, Mathieu Desnoyers, linux-mm The macro include/linux/mmzone.h:get_pageblock_migratetype() uses the symbol get_pfnblock_flags_mask, which is not exported. That macro is used within the kmem and page_ref trace events to trace the migrate type of the target page. Exporting this symbol to GPL modules allows GPL kernel tracers to be implemented as modules. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-mm@kvack.org --- mm/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 114c56c3685d..390febb028a0 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -501,6 +501,7 @@ unsigned long get_pfnblock_flags_mask(struct page *page, unsigned long pfn, { return __get_pfnblock_flags_mask(page, pfn, end_bitidx, mask); } +EXPORT_SYMBOL_GPL(get_pfnblock_flags_mask); static __always_inline int get_pfnblock_migratetype(struct page *page, unsigned long pfn) { -- 2.17.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC PATCH 6/9] mm: export-GPL get_pageblock_migratetype 2020-04-09 19:35 ` [RFC PATCH 6/9] mm: export-GPL get_pageblock_migratetype Mathieu Desnoyers @ 2020-04-12 8:14 ` Christoph Hellwig 0 siblings, 0 replies; 2+ messages in thread From: Christoph Hellwig @ 2020-04-12 8:14 UTC (permalink / raw) To: Mathieu Desnoyers Cc: Thomas Gleixner, Will Deacon, akpm, Greg Kroah-Hartman, K . Prasad, Masami Hiramatsu, rostedt, Alexei Starovoitov, linux-kernel, linux-mm On Thu, Apr 09, 2020 at 03:35:40PM -0400, Mathieu Desnoyers wrote: > The macro include/linux/mmzone.h:get_pageblock_migratetype() uses > the symbol get_pfnblock_flags_mask, which is not exported. That macro is > used within the kmem and page_ref trace events to trace the migrate type > of the target page. > > Exporting this symbol to GPL modules allows GPL kernel tracers to be > implemented as modules. Which might make some sense if we had such intree modules (and then even some as we could have higher level functions). Without that is obviously is a no-go. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-12 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200409193543.18115-1-mathieu.desnoyers@efficios.com>
2020-04-09 19:35 ` [RFC PATCH 6/9] mm: export-GPL get_pageblock_migratetype Mathieu Desnoyers
2020-04-12 8:14 ` Christoph Hellwig
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox