From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7314C2BA19 for ; Sat, 11 Apr 2020 22:06:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FD3D20708 for ; Sat, 11 Apr 2020 22:06:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J4bOOn6Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FD3D20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B4918E00BA; Sat, 11 Apr 2020 18:06:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38BB08E0007; Sat, 11 Apr 2020 18:06:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C8DF8E00BA; Sat, 11 Apr 2020 18:06:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 1632A8E0007 for ; Sat, 11 Apr 2020 18:06:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D3D30A8E5 for ; Sat, 11 Apr 2020 22:06:52 +0000 (UTC) X-FDA: 76696959864.20.kiss73_763ca209abd4d X-HE-Tag: kiss73_763ca209abd4d X-Filterd-Recvd-Size: 4256 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Apr 2020 22:06:52 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id f13so6165927wrm.13 for ; Sat, 11 Apr 2020 15:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CT8vbEIXt/rtqjiLfFTHYgcGhI1PSosGnJ6VAYQC7l0=; b=J4bOOn6YtHKItlWGno1tp1PEe4m2yfp5kkTxtsAS6MCbWV06P2F6sxJW74C2I15Gxp lFsfsK0GkBnpRQv08c80DQzfDNO+3ZwFwfIozORFR4SJfL4ZWPfE8r+g9TtCvydaBreM khW2DB6szEu89TkWFM79SfyKOXufmxd4VR/hReWLFySw7lmGWyUfry9s5L83KizD12lz H57l94nzqXUonAtzr4npbteWssGs6BnRPi457b79GCjDRr80lpIsLp1a60eqhxgVtYjw nbWwgbVDrkFqvoPLCaWNVVVtvIKDuukhksn0JQS8eSgpFDf/NUZ5eNcmqLqwkbO3iRuZ 0ZCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=CT8vbEIXt/rtqjiLfFTHYgcGhI1PSosGnJ6VAYQC7l0=; b=s6/x72KksNBqJgqMsTdJsH/sDlRNtYK8cZSo2YuhIDdgMGE+bIySz19MJTx1oJ3slD 9lNJDOeqA4MtXu47oDpnr/GIE6V1lFqGM2RyCTSLvBPUYFSGlLEAf3uNzm1XNsxYH0Oj tTOx9q6Mb+dJTFoQQdeRhislLvyDmTXMwSg5y5sbgokKmc5wjTmpbfKZGl0TM/QyuH23 mvSnod6p9DFJH8lbABpY4c9mwVvP/0eH33l3JITO0fefbckfrqm6cq1Hq8qd5sbB8NQH 13PRtTBaiX3Eneet0Nk9wDaZc2Luzwt0LKKvBumag6ex+DrpYeEyp8rhcOfkWfig9wK2 8xKQ== X-Gm-Message-State: AGi0PuZEZdIfgQSGMNSyihziwj72mtebKTn1B51/CUVI2NfTiUDOoFFz MFRiXMU+Etsilj9PoexWpXw= X-Google-Smtp-Source: APiQypIz+Ny13+X6E72YzdSGV0lYHyYCJYuAyJJufKA2xXLmydZgb9kyHTbnnjQTaMWvjwlEQR0Ndw== X-Received: by 2002:adf:f443:: with SMTP id f3mr4493845wrp.117.1586642811354; Sat, 11 Apr 2020 15:06:51 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id p5sm8781090wrn.93.2020.04.11.15.06.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Apr 2020 15:06:50 -0700 (PDT) Date: Sat, 11 Apr 2020 22:06:50 +0000 From: Wei Yang To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rientjes@google.com, anshuman.khandual@arm.com, david@redhat.com Subject: Re: [Patch v3 0/5] mm/page_alloc.c: cleanup on check page Message-ID: <20200411220650.ncasijo276xgj6c2@master> Reply-To: Wei Yang References: <20200411220357.9636-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200411220357.9636-1-richard.weiyang@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 11, 2020 at 10:03:52PM +0000, Wei Yang wrote: >The patch set does some cleanup related to check page. > >1. Remove unnecessary bad_reason assignment >2. Remove bad_flags to bad_page() >3. Rename function for naming convention >4. Extract common part to check page > >Thanks suggestions from David Rientjes and Anshuman Khandual. Oops, miss the history. v3: * still just print the highest priority bad reason * remove the bad_flags to bad_page() v2: * merge two rename patches into extract patch * enable dump several reasons for __dump_page() > >Wei Yang (5): > mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison > mm/page_alloc.c: bad_flags is not necessary for bad_page() > mm/page_alloc.c: rename free_pages_check_bad() to > check_free_page_bad() > mm/page_alloc.c: rename free_pages_check() to check_free_page() > mm/page_alloc.c: extract check_[new|free]_page_bad() common part to > page_bad_reason() > > mm/page_alloc.c | 74 +++++++++++++++++++------------------------------ > 1 file changed, 28 insertions(+), 46 deletions(-) > >-- >2.23.0 -- Wei Yang Help you, Help me