From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253B0C2BBC7 for ; Sat, 11 Apr 2020 22:06:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D97C420708 for ; Sat, 11 Apr 2020 22:06:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MPplP1qZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D97C420708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 895DD8E00B9; Sat, 11 Apr 2020 18:06:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8469A8E0007; Sat, 11 Apr 2020 18:06:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75C4F8E00B9; Sat, 11 Apr 2020 18:06:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5983E8E0007 for ; Sat, 11 Apr 2020 18:06:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 21668181AEF1E for ; Sat, 11 Apr 2020 22:06:05 +0000 (UTC) X-FDA: 76696957890.21.car14_6f4d38b9e6401 X-HE-Tag: car14_6f4d38b9e6401 X-Filterd-Recvd-Size: 2768 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Apr 2020 22:06:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ke5AHRgjKB6B5LshHHJpXc9QzzD0ma5nt/GmtfMBEXo=; b=MPplP1qZyTt37DjzlIf+sILbB+ S75QjpllmJhSrLwkFp+9NkhFTWFmOy1rcLjkbyMM/NWVVyTwsZkN0/hec3BqUus0g35T8/rLg3BAh 1pKOsq6BJ5JTXjT9Dij8hONSxrdtilOXHXNvPTI+csRTPBaWPW9msNuI0S+UnvHOMPhfbdZmqazMn w3SsF+cLogyaOAmOpgQpKrqkDx9a1br7C423/KsKprhg0HsX/kScHqNS3WholxLBxHuEklG/Rb6/e tt74IXJ7lSYvqgb6c//XMbge6uYYwNj6KDPZAB5CowirRb3rtNhDaQFi276rw1AQ6Tj6se3k37jmF V/nE2MpQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNOGJ-0007NM-FQ; Sat, 11 Apr 2020 22:06:03 +0000 Date: Sat, 11 Apr 2020 15:06:03 -0700 From: Matthew Wilcox To: Linus Torvalds Cc: linux-fsdevel , Linux-MM , Linux Kernel Mailing List Subject: Re: [GIT PULL] Rename page_offset() to page_pos() Message-ID: <20200411220603.GI21484@bombadil.infradead.org> References: <20200411203220.GG21484@bombadil.infradead.org> <20200411214818.GH21484@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 11, 2020 at 03:02:40PM -0700, Linus Torvalds wrote: > On Sat, Apr 11, 2020 at 2:48 PM Matthew Wilcox wrote: > > > > I wasn't entirely forthcoming ... I actually want to introduce a new > > > > #define page_offset(page, x) ((unsigned long)(x) & (page_size(page) - 1)) > > No, no, no. > > THAT would be confusing. Re-using a name (even if you renamed it) for > something new and completely different is just bad taste. It would > also be a horrible problem - again - for any stable backport etc. > > Just call that "offset_in_page()" and be done with it. But we _have_ an offset_in_page() and it doesn't take a struct page argument. Reusing the name wouldn't be too bad because it would take two arguments, so nothing would inadvertently apply cleanly. Anyway, if you give me a decision on pgindex_t vs pgidx_t, I'll work that up before -rc1 closes.