From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B21C2BA2B for ; Sat, 11 Apr 2020 16:10:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5DFFF2078E for ; Sat, 11 Apr 2020 16:10:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kRmlEnZi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DFFF2078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA94C8E00AC; Sat, 11 Apr 2020 12:10:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5B918E0007; Sat, 11 Apr 2020 12:10:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D95CD8E00AC; Sat, 11 Apr 2020 12:10:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id C25C78E0007 for ; Sat, 11 Apr 2020 12:10:35 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 862CA180AD807 for ; Sat, 11 Apr 2020 16:10:35 +0000 (UTC) X-FDA: 76696062030.10.land54_3ede3c03deb20 X-HE-Tag: land54_3ede3c03deb20 X-Filterd-Recvd-Size: 2145 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Apr 2020 16:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y1VWrM4y7TTfx7Q4K24WRNgl/VLX1ohFxw8RDOwG5w8=; b=kRmlEnZi+5hpLOlKpxheZ+th5f wwNiR+d3IBp6kkSOUy4yrUO+iHgoP+t5b+UR5ddNrBb5wxmm9p5r+FA6JJKEI2NYF7Zl+oiFsYQrX XDtKCjxT/FL01e2KIr+1Fsgr6nlcq7AJhRTf/LtXyhNPSrv3NS8KZORvX4eiRzrfEzxrSvjldnKVa A5MP5r4a3+Mh39bJT5gSRV2Srj30EIP038MzIQ8R4cxblMfL1tuxGsaRvOGkp55NeKsliRcK8Ja7y qAlqp5QuBRLoeZLY6y/TgYm4bv9xaSj31H4EJv1Mdcur3N8GZ0LyOn9dHv8oTNsSxgw7XHSVkKl04 4VjLeQNg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNIi5-0001cr-JA; Sat, 11 Apr 2020 16:10:21 +0000 Date: Sat, 11 Apr 2020 09:10:21 -0700 From: Matthew Wilcox To: qiwuchen55@gmail.com Cc: akpm@linux-foundation.org, david@redhat.com, richard.weiyang@gmail.com, mhocko@suse.com, pankaj.gupta.linux@gmail.com, yang.shi@linux.alibaba.com, cai@lca.pw, bhe@redhat.com, linux-mm@kvack.org, chenqiwu Subject: Re: [RESEND PATCH 3/3] mm/vmscan: make several optimizations for isolate_lru_pages() Message-ID: <20200411161021.GD21484@bombadil.infradead.org> References: <1586599916-15456-1-git-send-email-qiwuchen55@gmail.com> <1586599916-15456-3-git-send-email-qiwuchen55@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1586599916-15456-3-git-send-email-qiwuchen55@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 11, 2020 at 06:11:56PM +0800, qiwuchen55@gmail.com wrote: > 1) Simplify the code of initializing some variables. > - unsigned long scan, total_scan, nr_pages; > + unsigned long scan = 0, total_scan = 0, nr_pages; > > - total_scan = 0; > - scan = 0; I do not find this to be a simplification.