From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE320C2BB85 for ; Fri, 10 Apr 2020 19:16:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0D8220769 for ; Fri, 10 Apr 2020 19:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gmVjI/VE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0D8220769 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 587058E0055; Fri, 10 Apr 2020 15:16:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5363E8E004D; Fri, 10 Apr 2020 15:16:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 425B48E0055; Fri, 10 Apr 2020 15:16:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 26B238E004D for ; Fri, 10 Apr 2020 15:16:21 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E14314DC4 for ; Fri, 10 Apr 2020 19:16:20 +0000 (UTC) X-FDA: 76692901320.07.bears94_1a466322ec415 X-HE-Tag: bears94_1a466322ec415 X-Filterd-Recvd-Size: 5549 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Apr 2020 19:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586546180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cv7iW9UAPEbptJQ7pxTuJ8mpCyBB8TXm9+xjBE0kLBw=; b=gmVjI/VETuwYAeYbrArpbQTmnjIYLVEW3o7HoX6keMIWotqjUhdnMrVum7SuOgzN5/w3AQ sIszYe5UdlmQHn7j1D9yv+xcgsOsAQEA5EuxDUh+Aj+fnNYozxVis3pL0l2rr9w08jTM9Y oMFH0FFjglivJtBA/Jdn6V+LYFJPdVQ= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-291-NTGKrnsQML600c0GQaZIYA-1; Fri, 10 Apr 2020 15:16:17 -0400 X-MC-Unique: NTGKrnsQML600c0GQaZIYA-1 Received: by mail-qv1-f69.google.com with SMTP id dh19so2345827qvb.23 for ; Fri, 10 Apr 2020 12:16:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mwSL4Svde7cDyREN44P4y94Qc6dx9Sv2bNY13UCrEho=; b=g7pgv7cx2j+lsMFIrEJWyTafrB5WwTGvHcv2G/jMFiC5dy43ULfON5Ay1MqItuat45 6HjQs4Gxqd39FfpiQaA4uuKZ+ezSUP1VjseTQXmOs3B9LqYiZxSF7k4DXuL1mZW5HYpN kUzFx7GlaQ27NSxrn4qXe42iIB1WlBNLyfytP2XBJtj+8ZZ22zRXAwwLJMhCfPsDLgt5 ROwyTr3I+KVobvIYttDI5hFRknd0L0moUEIawP+kLSEbuefGRII6buGtREqXkhqiz6Wi +hOaj5w+zuLjDdp2YCpSeavmkHFdsx800Ek5fZgu+wTm+m1fLHlDnplqga5N2pJ80DjQ Wd3w== X-Gm-Message-State: AGi0PubEbg50bGnUBNlmuad+PF5vCQIGOHlpRZYzEZ5ZotTJ1ogR/hER E3a49yIqt9YJ4Igzg3IyjGvJz37awmDRYPsbjzqu62luxYX/3pMcYZUAYxVe1/x3AUkC0AxjXWn 5/mDU7Z9GL9U= X-Received: by 2002:a05:620a:89d:: with SMTP id b29mr5792236qka.329.1586546177443; Fri, 10 Apr 2020 12:16:17 -0700 (PDT) X-Google-Smtp-Source: APiQypLiuHO8rQfrWs/w6IUs43Srn34pCDFpZie/ieWUpJNT3bX04my6S/Xtwb+5j5ZmCFgzwIqbpg== X-Received: by 2002:a05:620a:89d:: with SMTP id b29mr5792202qka.329.1586546177111; Fri, 10 Apr 2020 12:16:17 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id b13sm1590230qtp.46.2020.04.10.12.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 12:16:16 -0700 (PDT) Date: Fri, 10 Apr 2020 15:16:13 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Dave Hansen , Jonathan Corbet , Longpeng , Christophe Leroy , Mina Almasry , Andrew Morton Subject: Re: [PATCH v2 1/4] hugetlbfs: add arch_hugetlb_valid_size Message-ID: <20200410191613.GD3172@xz-x1> References: <20200401183819.20647-1-mike.kravetz@oracle.com> <20200401183819.20647-2-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20200401183819.20647-2-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 01, 2020 at 11:38:16AM -0700, Mike Kravetz wrote: > diff --git a/arch/arm64/include/asm/hugetlb.h b/arch/arm64/include/asm/hu= getlb.h > index 2eb6c234d594..81606223494f 100644 > --- a/arch/arm64/include/asm/hugetlb.h > +++ b/arch/arm64/include/asm/hugetlb.h > @@ -59,6 +59,8 @@ extern void huge_pte_clear(struct mm_struct *mm, unsign= ed long addr, > extern void set_huge_swap_pte_at(struct mm_struct *mm, unsigned long add= r, > =09=09=09=09 pte_t *ptep, pte_t pte, unsigned long sz); > #define set_huge_swap_pte_at set_huge_swap_pte_at > +bool __init arch_hugetlb_valid_size(unsigned long size); > +#define arch_hugetlb_valid_size arch_hugetlb_valid_size Sorry for chimming in late. Since we're working on removing arch-dependent codes after all.. I'm thinking whether we can define arch_hugetlb_valid_size() once in the common header (e.g. linux/hugetlb.h), then in mm/hugetlb.c: bool __init __attribute((weak)) arch_hugetlb_valid_size(unsigned long size) { =09return size =3D=3D HPAGE_SIZE; } We can simply redefine arch_hugetlb_valid_size() in arch specific C files where we want to override the default. Would that be slightly cleaner? Thanks, --=20 Peter Xu