From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F56EC2BA2B for ; Fri, 10 Apr 2020 14:34:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38D7B20CC7 for ; Fri, 10 Apr 2020 14:34:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38D7B20CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C726A8E003C; Fri, 10 Apr 2020 10:34:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C22798E0003; Fri, 10 Apr 2020 10:34:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B38BD8E003C; Fri, 10 Apr 2020 10:34:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 9C85F8E0003 for ; Fri, 10 Apr 2020 10:34:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 561CE181AEF32 for ; Fri, 10 Apr 2020 14:34:58 +0000 (UTC) X-FDA: 76692192276.08.sky97_2b5d705651601 X-HE-Tag: sky97_2b5d705651601 X-Filterd-Recvd-Size: 3542 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Apr 2020 14:34:57 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id g6so1044549pgs.9 for ; Fri, 10 Apr 2020 07:34:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yiasH6wCnDGCTdH9mzlfIlSZUoRnw4cIEE89UnT/Y/c=; b=SJAC/WEFQgaJHzL8KqHByEkAJItqSKzPh1JkTngm+Va1JqgkSHHXbz02FH3ACWwFvY n4oMSjMMnVoycJhq11EXzvgugv2vrWIa8LUlJwghyxBjVpGE/kGjm47/+he+Aqw1PyDO wf9N/0LJkOK/U2a/m5baGTBSOqbfbFihGiyqsuhYZim9jcqJuWM+uf4IwkcIFh4H6V/i iAG2HomFcMc3k1zcWy/6a/VRANTUiBHl4/03qi4rqv2vGNSgEdJsqf6k/1oNu+09LQIc ZfXzExBFsM3ozhTrMhX8pmLfHrYIgznrXAlTL3PovtpCFvjoqS1Sv1BH+W+6DebCULs7 7ncA== X-Gm-Message-State: AGi0Pub+/3ZDrmlavhYe6nH8hQClsNE55Hf+MXtL9dk6ArPdhatul0Wc qG9FUdYtbSQloxoAt94s1sw= X-Google-Smtp-Source: APiQypLWmTwZhj96obnuL8BMloW/igvcDJXIQg366hd4jfScUoh9JrDWnnjg3g++vQtKj/IO2ajdvA== X-Received: by 2002:a63:741a:: with SMTP id p26mr5078048pgc.40.1586529296982; Fri, 10 Apr 2020 07:34:56 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id j24sm1918955pji.20.2020.04.10.07.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 07:34:56 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id D3C5940630; Fri, 10 Apr 2020 14:34:54 +0000 (UTC) Date: Fri, 10 Apr 2020 14:34:54 +0000 From: Luis Chamberlain To: Bart Van Assche Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org, mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Omar Sandoval , Hannes Reinecke , Michal Hocko Subject: Re: [RFC v2 4/5] mm/swapfile: refcount block and queue before using blkcg_schedule_throttle() Message-ID: <20200410143454.GL11244@42.do-not-panic.com> References: <20200409214530.2413-1-mcgrof@kernel.org> <20200409214530.2413-5-mcgrof@kernel.org> <5001fb4f-28b8-26b1-fc66-11b3105b15b9@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5001fb4f-28b8-26b1-fc66-11b3105b15b9@acm.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 09, 2020 at 08:02:59PM -0700, Bart Van Assche wrote: > On 2020-04-09 14:45, Luis Chamberlain wrote: > > if (si->bdev) { > > + bdev = bdgrab(si->bdev); > > + if (!bdev) > > + continue; > > + /* > > + * By adding our own bdgrab() we ensure the queue > > + * sticks around until disk_release(), and so we ensure > > + * our release of the request_queue does not happen in > > + * atomic context. > > + */ > > blkcg_schedule_throttle(bdev_get_queue(si->bdev), > > true); > > How about changing the si->bdev argument of blkcg_schedule_throttle() > into bdev? Sure, thanks! Luis