From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6946C2BA19 for ; Thu, 9 Apr 2020 22:18:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7F9C02083E for ; Thu, 9 Apr 2020 22:18:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qn7OqK0C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F9C02083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A5E78E0020; Thu, 9 Apr 2020 18:18:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22F258E0003; Thu, 9 Apr 2020 18:18:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11E1E8E0020; Thu, 9 Apr 2020 18:18:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 020D88E0003 for ; Thu, 9 Apr 2020 18:18:28 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C1FAC8248068 for ; Thu, 9 Apr 2020 22:18:27 +0000 (UTC) X-FDA: 76689731454.30.class74_66f15da89b737 X-HE-Tag: class74_66f15da89b737 X-Filterd-Recvd-Size: 5007 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 22:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586470706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/1Q1I9MOMyFYfJ7PabDUA5B/MfU8fpP9sYB55h0el8=; b=Qn7OqK0Cr2DspF47djK0gl4IafRhsS344/hJLFxi4DkHETAJzXSeZrq2e8dU72nBUzQsgh BRh7UTaWnFxOVoDUOM8hIoK13bG+2YRlvfeOeVJEfeBar3V9ovmCAsYu2lRfK6VE/ZTTJJ dsGjzsoLifh9qQKjWKZ0DY+L7kTE/Ak= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-72NJK2NXOJS2RrMXaKRFgQ-1; Thu, 09 Apr 2020 18:18:23 -0400 X-MC-Unique: 72NJK2NXOJS2RrMXaKRFgQ-1 Received: by mail-qk1-f198.google.com with SMTP id w21so447317qkj.18 for ; Thu, 09 Apr 2020 15:18:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wak+4fOkmGwWiUN+MnpwHwLxfkg3pyB2FLjyHTCXGe0=; b=S5TQE36SHnJw535ulaoxE4pOB34PpaYysEkGRGNLhcJNdzvKyShEXuqLV9MRiVOKQu PYJ4nsRRfNZGvaYGERvAmR1/Xhv65n+Cd+vTRO9/LE7YE0iw3lxwJfQMehaE8dSGVITE AxpRymfrE8SU0b9BiqfGPok+9Swt9rIV9JoyRqTSV7LRnBhutI2a/GXDYSTK5pw8E2uu wDQ6ncpju0i4abNhtjBTLxEMrXXTTqqsDG6XfvVg44Eu3bJvWZPhJDAfNt19HRAbypXx qPSSHsdJJL1JlC/wCITDcAzgoPbWsZ016DEKha6vQO3E3nPAYOMXo0O01beiJAMzeKq6 vizA== X-Gm-Message-State: AGi0Pub0H9SQX4VTcpRSzxcOqld30gC1CtJtjDhjIkRBDLl9qPGzoEvC 0gdkDS038uWitbHFv7I2ezkn57npZhCGFH/mcepHJ0lg6kpWOzCoM2NqQ8u/oI+6fzHWP4SVJC7 vAEy4gRiZe8c= X-Received: by 2002:a37:4117:: with SMTP id o23mr1141045qka.295.1586470702716; Thu, 09 Apr 2020 15:18:22 -0700 (PDT) X-Google-Smtp-Source: APiQypIJD/iTRAWfSQIyFtDJJdk3323wKWVJn7GNTy0DpExPfZvgf67+NsccoV0ON/i9YnqzueJ/4g== X-Received: by 2002:a37:4117:: with SMTP id o23mr1141019qka.295.1586470702419; Thu, 09 Apr 2020 15:18:22 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id o18sm165603qkk.52.2020.04.09.15.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 15:18:21 -0700 (PDT) Date: Thu, 9 Apr 2020 18:18:19 -0400 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Nitesh Narayan Lal , Andrew Morton Subject: Re: [PATCH] Documentation: hugetlb: Update hugetlb options Message-ID: <20200409221819.GA3172@xz-x1> References: <20200409215800.8967-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 09, 2020 at 03:08:07PM -0700, Mike Kravetz wrote: > On 4/9/20 2:58 PM, Peter Xu wrote: > > The hugepage options are not documented clearly. > >=20 > > Firstly, default_hugepagesz=3D should always be specified after the > > declaration of the same type of huge page using hugepagesz=3D. For > > example, if we boot a x86_64 system with kernel cmdline > > "default_hugepagesz=3D2M", we'll get a very funny error message: > >=20 > > "HugeTLB: unsupported default_hugepagesz 2097152. Reverting to 2097152" > >=20 > > It's understandable from code-wise because when hugetlb_init() we > > didn't have the 2M page hstate registered, so it's unsupported. > > However 2M is actually the default huge page size on x86_64, so we'll > > register it right after the error message. However it's very > > confusing if without these knowledges. > >=20 > > Secondly, hugepages=3D option must be used _after_ another hugepagesz= =3D. > > The word "interleave" is fine but it didn't declare the fact that > > each of the hugepages=3D option will be applied to the previous parsed > > hugepagesz=3D option. > >=20 > > State all these clear. > >=20 > > Signed-off-by: Peter Xu >=20 > Hi Peter, >=20 > Did you happen to see this patch series? >=20 > https://lore.kernel.org/linux-mm/20200401183819.20647-1-mike.kravetz@orac= le.com/ >=20 > That should address the documentation issue and more. Great! I missed that, but I'll definitely read it (probably tomorrow). Let's ignore this patch then. Thanks, --=20 Peter Xu