From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A95C2BA2B for ; Thu, 9 Apr 2020 14:47:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 566C220692 for ; Thu, 9 Apr 2020 14:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="OPTkeuJb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 566C220692 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F1A848E000D; Thu, 9 Apr 2020 10:47:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECBA38E0006; Thu, 9 Apr 2020 10:47:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBAF48E000D; Thu, 9 Apr 2020 10:47:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id CC6CE8E0006 for ; Thu, 9 Apr 2020 10:47:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9BE61181AEF00 for ; Thu, 9 Apr 2020 14:47:47 +0000 (UTC) X-FDA: 76688595774.22.blade99_611ca2c1f7f10 X-HE-Tag: blade99_611ca2c1f7f10 X-Filterd-Recvd-Size: 4100 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 14:47:47 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id x23so8111224lfq.1 for ; Thu, 09 Apr 2020 07:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZaCosul53ZVQ/K4wOVNqLgJJvDBfTfQxFjxkw0uhocE=; b=OPTkeuJb7qcs1t0f0PaWDd6oHYFN4CVNGeOqGkh9AnjHhAfW94ffizb92mWZoaa0zo F1+a3hWVk6G3GXxZnf85iyghpo3v8ZQn1mHAQXR/AXOGROHr1ZMGYWXb9LPIlu/q2l0f 6H125iVDm9pInDySk43qld4EVxtfnknrR209Tlz2tmOqqvyDOlP7+wKFTxYo5AkgO+CQ yQ0yPruLrqXN9GAVyxSDeW00c/xpQ3u13d1SBxJZbwrW2sON4LSYtsR/aQ3dK4alteTo 7Bkkr5fZj5zE9R+HrMgEK8rHnQ8UR3pSJISLQeu4hky6Mr1g3znji29jKcdy7OE9YC/h Gsiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZaCosul53ZVQ/K4wOVNqLgJJvDBfTfQxFjxkw0uhocE=; b=k7DdzO+fnYBjN6B4buUHyKdFk0OFlTLpXuOfJAIpmEnpSWpHqaEv36JT3JlJ5YmPkd gConzWyonSI7YvQwbBNoQQz1TUoMO3dFW069pTTCAtEWeflv53IUZnu8pbpykHhe1UKo Hq4OiBN0lqqg4Yhj8my4OgSxsEVoYlp0sVqoRHWg120H8H12xd/dP4okbKyX+rsoLFLO so15zlObux0WaPJoKWYkQx6zGqsIU5Ko01Gp/6Gyy/3l2Q9oPDTlnxkjOnxI83TGkkqm a6S249x5JbRiMyLiKnRejpqD+0gQGoBVj3oWLz0EgYccEpz69Rp0slzO09XY3O7FLcHJ y2FA== X-Gm-Message-State: AGi0PuaAKvDdDak1cTa40VmmbhGeQ8dAqkKMRDSbcYYRsqDvv0SkIhW6 3Gx/PpEAj5CZZQsqpAyZbfoS9Q== X-Google-Smtp-Source: APiQypJzYOXctwvQec3AIr+bSSt+IKEjF/Ijkeo3M3O2e3V1kJ9y+0CX9ZARXVNxroCNGvfePNWbXQ== X-Received: by 2002:ac2:5042:: with SMTP id a2mr3219585lfm.13.1586443665699; Thu, 09 Apr 2020 07:47:45 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id k18sm19319825lfg.81.2020.04.09.07.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:47:45 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 8D984102132; Thu, 9 Apr 2020 17:47:44 +0300 (+03) Date: Thu, 9 Apr 2020 17:47:44 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, pasha.tatashin@soleen.com Subject: Re: [PATCH 1/5] mm: Constify a lot of struct page arguments Message-ID: <20200409144744.25bloz245hmtr5rm@box> References: <20200408150148.25290-1-willy@infradead.org> <20200408150148.25290-2-willy@infradead.org> <20200409140914.u3mff4xrk5u4tvht@box> <20200409141550.GU21484@bombadil.infradead.org> <20200409142851.obndv6u7wpo2zovj@box> <20200409143238.GV21484@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409143238.GV21484@bombadil.infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000565, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 09, 2020 at 07:32:38AM -0700, Matthew Wilcox wrote: > On Thu, Apr 09, 2020 at 05:28:51PM +0300, Kirill A. Shutemov wrote: > > > We have a few places that do things like > > > > > > mm/filemap.c: if (unlikely(compound_head(page)->mapping != mapping)) { > > > > Good point. > > > > Acked-by: Kirill A. Shutemov > > Darn, I hoped you'd have a better idea. I feel quite ashamed of this patch. I had two ideas. Both awful. - Rename compound_head() to __compound_head() or something and make it return void *. Then wrap it into a macro that would cast return type to type of the argument. It would allow to regain *some* type safety. - Provide two implementations and use C11 _Generic() :P (bump GCC version requirements first) -- Kirill A. Shutemov