From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5032FC2BA2B for ; Thu, 9 Apr 2020 14:32:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1C0DF21556 for ; Thu, 9 Apr 2020 14:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DpHxcXG2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C0DF21556 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA4EB8E000D; Thu, 9 Apr 2020 10:32:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B549A8E0006; Thu, 9 Apr 2020 10:32:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6A3D8E000D; Thu, 9 Apr 2020 10:32:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 993628E0006 for ; Thu, 9 Apr 2020 10:32:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 725C3180AD81D for ; Thu, 9 Apr 2020 14:32:43 +0000 (UTC) X-FDA: 76688557806.11.flock09_6f10437a35761 X-HE-Tag: flock09_6f10437a35761 X-Filterd-Recvd-Size: 2134 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 14:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yrMcN7Vn9UcZPC7t2YYydf78EGiDz6yjwmHTlNh62gM=; b=DpHxcXG2jr1QxQ9BMXQym6y26T btT7PwuLeft7uw7OZdVmjnfsr9RhPxsvP/H4h8/9pmmJ8sExqnQnq/MiRXP7mDesZgF/m80T6dn6A I3NnRXUx88N/AOAJy/S6hk7IuCrTpIsTYkpk/VCqAPKcA1/BB88SLWsbRZe9+wQx7MgIuD6PqlW+F bfQorsTCphw9EWrXoEg12xni0W24ZGEJkxoivbx5HQx3jmp/mNXY2/bY9wx6SKq2ux2EQ+1HfzDua ptCx7070shBYp/4Xa8dduxaIwab0MnQsZPTU+oublVAFRdY8rFifwyw0ScZ1rT3Sg4pmRrFjmJ+r8 jy06SXlA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMYEQ-0008H9-Tn; Thu, 09 Apr 2020 14:32:38 +0000 Date: Thu, 9 Apr 2020 07:32:38 -0700 From: Matthew Wilcox To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, pasha.tatashin@soleen.com Subject: Re: [PATCH 1/5] mm: Constify a lot of struct page arguments Message-ID: <20200409143238.GV21484@bombadil.infradead.org> References: <20200408150148.25290-1-willy@infradead.org> <20200408150148.25290-2-willy@infradead.org> <20200409140914.u3mff4xrk5u4tvht@box> <20200409141550.GU21484@bombadil.infradead.org> <20200409142851.obndv6u7wpo2zovj@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409142851.obndv6u7wpo2zovj@box> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 09, 2020 at 05:28:51PM +0300, Kirill A. Shutemov wrote: > > We have a few places that do things like > > > > mm/filemap.c: if (unlikely(compound_head(page)->mapping != mapping)) { > > Good point. > > Acked-by: Kirill A. Shutemov Darn, I hoped you'd have a better idea. I feel quite ashamed of this patch.