From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
pasha.tatashin@soleen.com
Subject: Re: [PATCH 5/5] mm: Check page poison before finding a head page
Date: Thu, 9 Apr 2020 17:25:06 +0300 [thread overview]
Message-ID: <20200409142506.7m3kq624q2q7ltwa@box> (raw)
In-Reply-To: <20200408150148.25290-6-willy@infradead.org>
On Wed, Apr 08, 2020 at 08:01:48AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> If a page is poisoned, the page->compound_head will be set to -1.
> Since it has bit zero set, we will think it is a tail page, and the head
> page is at 0xff..fe. Checking said head page for being poisoned will
> not have good results. Therefore we need to check for poison in each
> of compound_head(), PageTail() and PageCompound() (and can remove the
> checks which are now redundant from the PF_ macros).
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-04-09 14:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 15:01 [PATCH 0/5] Improve page poisoning implementation Matthew Wilcox
2020-04-08 15:01 ` [PATCH 1/5] mm: Constify a lot of struct page arguments Matthew Wilcox
2020-04-08 15:14 ` Pavel Tatashin
2020-04-09 14:09 ` Kirill A. Shutemov
2020-04-09 14:15 ` Matthew Wilcox
2020-04-09 14:28 ` Kirill A. Shutemov
2020-04-09 14:32 ` Matthew Wilcox
2020-04-09 14:47 ` Kirill A. Shutemov
2020-04-09 15:00 ` Kirill A. Shutemov
2020-04-09 17:12 ` Jason Gunthorpe
2020-04-09 20:47 ` John Hubbard
2020-04-08 15:01 ` [PATCH 2/5] mm: Rename PF_POISONED_PAGE to page_poison_check Matthew Wilcox
2020-04-08 15:21 ` Pavel Tatashin
2020-04-09 14:14 ` Kirill A. Shutemov
2020-04-08 15:01 ` [PATCH 3/5] mm: Remove casting away of constness Matthew Wilcox
2020-04-08 15:23 ` Pavel Tatashin
2020-04-09 14:19 ` Kirill A. Shutemov
2020-04-08 15:01 ` [PATCH 4/5] mm: Check for page poison in both page_to_nid implementations Matthew Wilcox
2020-04-08 15:24 ` Pavel Tatashin
2020-04-09 14:21 ` Kirill A. Shutemov
2020-04-08 15:01 ` [PATCH 5/5] mm: Check page poison before finding a head page Matthew Wilcox
2020-04-08 15:32 ` Pavel Tatashin
2020-04-09 14:25 ` Kirill A. Shutemov [this message]
2020-04-08 15:11 ` [PATCH 0/5] Improve page poisoning implementation Pavel Tatashin
2020-04-09 20:55 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200409142506.7m3kq624q2q7ltwa@box \
--to=kirill@shutemov.name \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox