From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B66C7C2BA2B for ; Thu, 9 Apr 2020 14:19:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A6642083E for ; Thu, 9 Apr 2020 14:19:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="2EAz15E3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A6642083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1EAE28E000E; Thu, 9 Apr 2020 10:19:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 199B98E0006; Thu, 9 Apr 2020 10:19:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062E98E000E; Thu, 9 Apr 2020 10:19:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id EF5148E0006 for ; Thu, 9 Apr 2020 10:19:54 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 86812582B for ; Thu, 9 Apr 2020 14:19:54 +0000 (UTC) X-FDA: 76688525508.03.top89_90add1ded9d3e X-HE-Tag: top89_90add1ded9d3e X-Filterd-Recvd-Size: 3549 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 14:19:54 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id h6so8085013lfc.0 for ; Thu, 09 Apr 2020 07:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TGS83ydCIOdEW6A8oBgy/2c2YUjeShTMudkxt6LqRa4=; b=2EAz15E356UFMJ3HzFko0z/fH+65LiU2hATS4wZEuYdadT15Uk1q5bJStS94SWhPPE MNrax6Eeio1d6KNNVhfpJ9rw/i6YyGAzs9xAigo8hv4xUhXMVb8oQ3nTkmKDaWrf/1XY klxOQTOUsZ1NtbhvWyBzZw3iBd49THrmUOLtKLtUuYQd742KUBDQ1FVEUHk7029asBYm XnV8K21XEdFtNDDxRsl9j6ii5FSSD5J2/94EqeTVPmESCxlnlKsXt6iy+rJCPwYFVsO0 Pj+8xxFeqRqmS5sY63KJppF9ZP4vAa7hOuCukSLHvxRFGPqLVTWw+ZgtOykuLx+Z85QN gOxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TGS83ydCIOdEW6A8oBgy/2c2YUjeShTMudkxt6LqRa4=; b=SQYRc5nBtf0A0wArPidq4UBSTQtcF3EE4XNPlVJZutZeSCozHjMlkyGNmYNzA2Vj5p zRYp628Pygr5gxZNRRb1cU3rDuIa7cAipv42V8F3m+M1Wb+X/BRUsHXD1sGs2YfYrVLO 6yhWuLTASmlFqwh+mdmq9ztk9SgrV7DJmjtcnPvKCQ6yvAuPRWzeJrVDHwwsQN0A/vwM Ed7YxHBMlpzX1gtH0/ylPfFTK7K7ItgWwmnT10Unoy8nCf4PA1DQ0JZSTkrRJ0ppYper Vx/yMy1L/klkGuHWWa5bUIpWo4ArfjHCzmMFEI6A7/zdd2teyb3N8RndnlBbCEwywbc7 Cb9w== X-Gm-Message-State: AGi0PuY/EdxOuvkEccmhRN6meufIvICCRJqJldgdJj5DoZg3qZ3mB39e 6kQ2l7r8CsE25QvQQJsvrY3Slg== X-Google-Smtp-Source: APiQypJP7okCw0k5LPYiO9g/oCvgFxS4Xe9pWztujct3zz9e0ICBXaIPBgyUy6ez7BqggoTZoZ/jKw== X-Received: by 2002:ac2:5ec5:: with SMTP id d5mr2453234lfq.142.1586441992680; Thu, 09 Apr 2020 07:19:52 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id x5sm1007165ljh.97.2020.04.09.07.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:19:51 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id F3089102132; Thu, 9 Apr 2020 17:19:50 +0300 (+03) Date: Thu, 9 Apr 2020 17:19:50 +0300 From: "Kirill A. Shutemov" To: Matthew Wilcox Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, pasha.tatashin@soleen.com Subject: Re: [PATCH 3/5] mm: Remove casting away of constness Message-ID: <20200409141950.om6tklkqzc52ti3b@box> References: <20200408150148.25290-1-willy@infradead.org> <20200408150148.25290-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408150148.25290-4-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 08, 2020 at 08:01:46AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > Now that dump_page can take a const struct page pointer, we can get rid ^ () > of the cast in page_to_nid(). It took me a minute to understand how page_to_nid() related to dump_page(). Please elaborate in the commit message. Otherwise, looks good. Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov