From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3BFC2BA2B for ; Thu, 9 Apr 2020 14:07:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0144C208FE for ; Thu, 9 Apr 2020 14:07:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0144C208FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9460F8E000D; Thu, 9 Apr 2020 10:07:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F69C8E0006; Thu, 9 Apr 2020 10:07:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80C4D8E000D; Thu, 9 Apr 2020 10:07:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 76C768E0006 for ; Thu, 9 Apr 2020 10:07:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 493B9180AD81F for ; Thu, 9 Apr 2020 14:07:33 +0000 (UTC) X-FDA: 76688494386.13.wish94_24cf684a9025e X-HE-Tag: wish94_24cf684a9025e X-Filterd-Recvd-Size: 3942 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 14:07:32 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id c15so12015677wro.11 for ; Thu, 09 Apr 2020 07:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y3QdGz4ivlJwbyK5tt1hprydewj+9Vhj8i9nSBCdCDE=; b=t/vMIgSFBf+0TGIg4piQdGMm+amhlBykkDmIIJN7vhgVYmJGpmjFpXOMwzZy/ynPa0 WXEscT3A2EfWLts8AUusOmF9e+0VFbtCKsMkQWgvf7THvoJZAzFfA/O6jWiCTW3Txs4O v2ElG3QdYV763AZliR9uXAqMEe5xM9MtE0unHdAWQVUczIKcNq5z2FV35aUaVLlV4Mpp BH/B08AH8s0GrqAAaDwmRFp1jfZHkdYZpPlcWg7wbVDAfYev4snUDSI42pgD1spPQB59 66wvjqS3RM1Li7P41lTI7/Jkc9FvfkXdFwUr9KgyNpiDotldR5+EZpTEkgD0vaxrnyE8 mZGg== X-Gm-Message-State: AGi0PuYFsw6gXSxGOqWM6rLOnWN50S7Jq/z02FTrQFfdT1K7UQc2jtBn m4ngAiKOvL6ZNlmNZtXIrWE= X-Google-Smtp-Source: APiQypIbdij3HeXgcGl7TZVEU50Zrs7+pTTRvr08+mNfYbk9SGFHf/5ZC5e7/8lmWv/nFQ4ZZOnqjw== X-Received: by 2002:a5d:63c3:: with SMTP id c3mr11787894wrw.237.1586441251874; Thu, 09 Apr 2020 07:07:31 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id t16sm3871561wmi.27.2020.04.09.07.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:07:31 -0700 (PDT) Date: Thu, 9 Apr 2020 16:07:29 +0200 From: Michal Hocko To: Yafang Shao Cc: Andrew Morton , Johannes Weiner , Matthew Wilcox , Vladimir Davydov , Linux MM Subject: Re: [PATCH v3] mm, memcg: fix error return value of mem_cgroup_css_alloc() Message-ID: <20200409140729.GL18386@dhcp22.suse.cz> References: <20200406200916.2623f34403155264d8c8e9e7@linux-foundation.org> <20200407064329.GB18914@dhcp22.suse.cz> <20200407111017.GN18914@dhcp22.suse.cz> <20200407181012.GA12461@cmpxchg.org> <20200408182956.0906ebc4f8ec421689ec6df5@linux-foundation.org> <20200409065722.GA18386@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 09-04-20 21:59:42, Yafang Shao wrote: > On Thu, Apr 9, 2020 at 2:57 PM Michal Hocko wrote: > > > > On Wed 08-04-20 18:29:56, Andrew Morton wrote: > > > On Tue, 7 Apr 2020 14:10:12 -0400 Johannes Weiner wrote: > > > > > > > Given how unlikely this is to affect real setups, I don't think this > > > > patch is stable material. > > > > > > OK, thanks, done. > > > > > > I didn't notice any acks - is this patch otherwise good to go upstream? > > > > I will ack it if s@EBUSY@ENOSPC@ > > > > BTW, there's no EBUSY in man page of write(2) neither. > But when we echo some procs into cgroup.subtree_control of a non-root > cgroup, it will return EBUSY. See also cgroup_subtree_control_write(). > Pls. correct me if I missed something. > > We have to admit that the man page is out of date. Or the code is returning something unexpected but nobody has noticed so far. Please talk to cgroup maintainers on how to address that. -- Michal Hocko SUSE Labs