From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 676BCC2D0EA for ; Thu, 9 Apr 2020 08:49:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 176DB22202 for ; Thu, 9 Apr 2020 08:49:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 176DB22202 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 923CE8E000D; Thu, 9 Apr 2020 04:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D3E88E0006; Thu, 9 Apr 2020 04:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C24A8E000D; Thu, 9 Apr 2020 04:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 6DAD08E0006 for ; Thu, 9 Apr 2020 04:49:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 416C2801C748 for ; Thu, 9 Apr 2020 08:49:09 +0000 (UTC) X-FDA: 76687692018.10.crime80_15af0c9a48606 X-HE-Tag: crime80_15af0c9a48606 X-Filterd-Recvd-Size: 5451 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 08:49:08 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id r26so3368865wmh.0 for ; Thu, 09 Apr 2020 01:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4R4O9Mkhw/Z10RizEohDCqkt7FovGhxpIg1sEVkIfyM=; b=Bx6lRIaew7/IFg0CmvuwDOeM+SzoCqWdQmpvXSJaS6DjcHRi0jAFe5HDlfWc5Cxxuc VWsjGYfzO8Tmjhci+hOYWfBx/UV6NzMd5ZOpKlJB59HfsagudWAIPpyg5wQnF4+MMEU0 yTetTY5fJ4Ywuwe7gBIqVmVSksd7nqEkQeT6znviOuz8Oz/0iD4OkbVkv18F04C9PBgo KCEHC9PVHlAsXTHO6y7HNntYctX7+ONJbwT0pnd7uixFadrKQSUVDYTa4o1HEVDzCSRj WLUjLiSeWe5XWSkmPcrTHUbKLvRPIicKDsMyelrPOePc9nJyNj9Q80PcTH+yrG9xwN12 nAbA== X-Gm-Message-State: AGi0Pub5vssBxNDtbixGQd7CCNnDfYfuAL8PkNnN5hldTyVpm4qf0+1m /7HmnwcKRpJ9A63aWA+FHYM= X-Google-Smtp-Source: APiQypK+OnoBoW3IE7Y1FFhgVv8w8+vOScKrnNyOUHK/KS/1bwzbuAjaycK7cVwiF8cZW0fV5ZDuaQ== X-Received: by 2002:a1c:2d8b:: with SMTP id t133mr9351094wmt.131.1586422147743; Thu, 09 Apr 2020 01:49:07 -0700 (PDT) Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223]) by smtp.gmail.com with ESMTPSA id 145sm3063271wma.1.2020.04.09.01.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 01:49:07 -0700 (PDT) Date: Thu, 9 Apr 2020 10:49:06 +0200 From: Michal Hocko To: David Hildenbrand Cc: Michael Ellerman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Nathan Fontenot , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , Oscar Salvador , Baoquan He , Wei Yang Subject: Re: [PATCH v1 1/2] powerpc/pseries/hotplug-memory: stop checking is_mem_section_removable() Message-ID: <20200409084906.GD18386@dhcp22.suse.cz> References: <20200407135416.24093-1-david@redhat.com> <20200407135416.24093-2-david@redhat.com> <87sghdjf1y.fsf@mpe.ellerman.id.au> <20200409075927.GC18386@dhcp22.suse.cz> <0a0ed3ed-f792-f8f7-07f4-cacc2b565a95@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a0ed3ed-f792-f8f7-07f4-cacc2b565a95@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 09-04-20 10:12:20, David Hildenbrand wrote: > On 09.04.20 09:59, Michal Hocko wrote: > > On Thu 09-04-20 17:26:01, Michael Ellerman wrote: > >> David Hildenbrand writes: > >> > >>> In commit 53cdc1cb29e8 ("drivers/base/memory.c: indicate all memory > >>> blocks as removable"), the user space interface to compute whether a memory > >>> block can be offlined (exposed via > >>> /sys/devices/system/memory/memoryX/removable) has effectively been > >>> deprecated. We want to remove the leftovers of the kernel implementation. > >>> > >>> When offlining a memory block (mm/memory_hotplug.c:__offline_pages()), > >>> we'll start by: > >>> 1. Testing if it contains any holes, and reject if so > >>> 2. Testing if pages belong to different zones, and reject if so > >>> 3. Isolating the page range, checking if it contains any unmovable pages > >>> > >>> Using is_mem_section_removable() before trying to offline is not only racy, > >>> it can easily result in false positives/negatives. Let's stop manually > >>> checking is_mem_section_removable(), and let device_offline() handle it > >>> completely instead. We can remove the racy is_mem_section_removable() > >>> implementation next. > >>> > >>> We now take more locks (e.g., memory hotplug lock when offlining and the > >>> zone lock when isolating), but maybe we should optimize that > >>> implementation instead if this ever becomes a real problem (after all, > >>> memory unplug is already an expensive operation). We started using > >>> is_mem_section_removable() in commit 51925fb3c5c9 ("powerpc/pseries: > >>> Implement memory hotplug remove in the kernel"), with the initial > >>> hotremove support of lmbs. > >> > >> It's also not very pretty in dmesg. > >> > >> Before: > >> > >> pseries-hotplug-mem: Attempting to hot-add 10 LMB(s) > >> pseries-hotplug-mem: Memory hot-add failed, removing any added LMBs > >> dlpar: Could not handle DLPAR request "memory add count 10" > > > > Yeah, there is more output but isn't that useful? Or put it differently > > what is the actual problem from having those messages in the kernel log? > > > > From the below you can clearly tell that there are kernel allocations > > which prevent hot remove from happening. > > > > If the overall size of the debugging output is a concern then we can > > think of a way to reduce it. E.g. once you have a couple of pages > > reported then all others from the same block are likely not interesting > > much. > > > > IIRC, we only report one page per block already. (and stop, as we > detected something unmovable) You are right. -- Michal Hocko SUSE Labs