From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C7E7C2BA1B for ; Wed, 8 Apr 2020 15:43:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3912B208FE for ; Wed, 8 Apr 2020 15:43:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3912B208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D834E8E000E; Wed, 8 Apr 2020 11:43:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33E98E0006; Wed, 8 Apr 2020 11:43:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C492F8E000E; Wed, 8 Apr 2020 11:43:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id A8D748E0006 for ; Wed, 8 Apr 2020 11:43:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 67B2A800FD14 for ; Wed, 8 Apr 2020 15:43:06 +0000 (UTC) X-FDA: 76685106372.28.ship34_55483d164ac0e X-HE-Tag: ship34_55483d164ac0e X-Filterd-Recvd-Size: 1417 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Apr 2020 15:43:05 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2262D68C4E; Wed, 8 Apr 2020 17:43:04 +0200 (CEST) Date: Wed, 8 Apr 2020 17:43:03 +0200 From: Christoph Hellwig To: Hillf Danton Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/28] mm: remove the prot argument from vm_map_ram Message-ID: <20200408154303.GB28676@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200408135240.6528-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408135240.6528-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000662, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 08, 2020 at 09:52:40PM +0800, Hillf Danton wrote: > > On Wed, 8 Apr 2020 13:59:15 +0200 Christoph Hellwig wrote: > > > > --- a/fs/xfs/xfs_buf.c > > +++ b/fs/xfs/xfs_buf.c > > @@ -474,7 +474,7 @@ _xfs_buf_map_pages( > > nofs_flag = memalloc_nofs_save(); > > do { > > bp->b_addr = vm_map_ram(bp->b_pages, bp->b_page_count, > > - -1, PAGE_KERNEL); > > + -1); > s/-1/NUMA_NO_NODE/ Not really relevant to this series, but otherwise agreed.