From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4D8C2BB1D for ; Tue, 7 Apr 2020 11:46:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 529DD20678 for ; Tue, 7 Apr 2020 11:46:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RL5pbRa8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 529DD20678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DDB1B8E0028; Tue, 7 Apr 2020 07:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8AE68E0001; Tue, 7 Apr 2020 07:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79858E0028; Tue, 7 Apr 2020 07:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id B0A468E0001 for ; Tue, 7 Apr 2020 07:46:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 72DF5180AD804 for ; Tue, 7 Apr 2020 11:46:18 +0000 (UTC) X-FDA: 76680880836.13.soup13_8e42ea08b7059 X-HE-Tag: soup13_8e42ea08b7059 X-Filterd-Recvd-Size: 4122 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 11:46:17 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A6BB59E; Tue, 7 Apr 2020 13:46:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1586259975; bh=ZrbMYApy/wtpTZfFXfei39k3EseDZq7sqpX6uXd/R/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RL5pbRa8YkHhLLrOEA+OTRmLWAKw8r8WLal9Ia6m3VimBh6adAYSav3vN2ugOPCwM vZOQqgCp2wLKBWtrYqZ2SJPLkR/h2NGz6GXnlOnb3MIOChCnlHR6uT5t2tCdZm+5pM JxVjW1yZl6yhlqd8P+PrjBe9WMKYRJteZFE2ZLHU= Date: Tue, 7 Apr 2020 14:46:05 +0300 From: Laurent Pinchart To: Andrew Morton Cc: airlied@linux.ie, daniel@ffwll.ch, jernej.skrabec@siol.net, joe@perches.com, jonas@kwiboo.se, linux-mm@kvack.org, lkundrak@v3.sk, mark.rutland@arm.com, mm-commits@vger.kernel.org, narmstrong@baylibre.com, robh@kernel.org, torvalds@linux-foundation.org Subject: Re: [patch 135/166] checkpatch: check proper licensing of Devicetree bindings Message-ID: <20200407114605.GA4751@pendragon.ideasonboard.com> References: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> <20200407031113.32cyhpO2F%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200407031113.32cyhpO2F%akpm@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew and Lubomir, Thank you for the patch. On Mon, Apr 06, 2020 at 08:11:13PM -0700, Andrew Morton wrote: > From: Lubomir Rintel > Subject: checkpatch: check proper licensing of Devicetree bindings > > According to Devicetree maintainers (see Link: below), the Devicetree > binding documents are preferrably licensed (GPL-2.0-only OR BSD-2-Clause). I think "preferrably" is a bit too weak: https://lore.kernel.org/lkml/CAL_JsqLYUooc-9i6U6Br9DQKPHZMrLJf3f883PeM4Ctbwycs8w@mail.gmail.com/ I'd thus use the error message level below, and s/should/shall/. Apart from that, Acked-by: Laurent Pinchart > Let's check that. The actual check is a bit more relaxed, to allow more > liberal but compatible licensing (e.g. GPL-2.0-or-later OR BSD-2-Clause). > > Link: https://lore.kernel.org/lkml/20200108142132.GA4830@bogus/ > Link: http://lkml.kernel.org/r/20200309215153.38824-1-lkundrak@v3.sk > Signed-off-by: Lubomir Rintel > Acked-by: Joe Perches > Cc: Rob Herring > Cc: Neil Armstrong > Cc: Laurent Pinchart , > Cc: Jonas Karlman , > Cc: Jernej Skrabec , > Cc: Mark Rutland , > Cc: David Airlie > Cc: Daniel Vetter , > Signed-off-by: Andrew Morton > --- > > scripts/checkpatch.pl | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > --- a/scripts/checkpatch.pl~checkpatch-check-proper-licensing-of-devicetree-bindings > +++ a/scripts/checkpatch.pl > @@ -3157,6 +3157,17 @@ sub process { > WARN("SPDX_LICENSE_TAG", > "'$spdx_license' is not supported in LICENSES/...\n" . $herecurr); > } > + if ($realfile =~ m@^Documentation/devicetree/bindings/@ && > + not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) { > + my $msg_level = \&WARN; > + $msg_level = \&CHK if ($file); > + if (&{$msg_level}("SPDX_LICENSE_TAG", > + > + "DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)\n" . $herecurr) && > + $fix) { > + $fixed[$fixlinenr] =~ s/SPDX-License-Identifier: .*/SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)/; > + } > + } > } > } > } > _ -- Regards, Laurent Pinchart