From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98BB4C2BA1A for ; Tue, 7 Apr 2020 03:09:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 52E1420936 for ; Tue, 7 Apr 2020 03:09:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NYIWCz9/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52E1420936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 068AC8E0001; Mon, 6 Apr 2020 23:09:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0187E8E0062; Mon, 6 Apr 2020 23:08:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54888E0001; Mon, 6 Apr 2020 23:08:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id CACCD8E0001 for ; Mon, 6 Apr 2020 23:08:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 895539096 for ; Tue, 7 Apr 2020 03:08:59 +0000 (UTC) X-FDA: 76679577198.30.wheel90_88b10d770c937 X-HE-Tag: wheel90_88b10d770c937 X-Filterd-Recvd-Size: 2252 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:08:59 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 451FC20801; Tue, 7 Apr 2020 03:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228938; bh=bEAuGf5pDsp+/wGaDAPM4R5kILQ9iFc5/zFK1CS8ZL0=; h=Date:From:To:Subject:In-Reply-To:From; b=NYIWCz9/G8f8yxSgi1bb8cEfBsMZMucB/SsiXH2dlABimR8umbeSNPQZ5tNvHgPFC dBSuahI8wsTAerbIdQ0nOagQwdyXfu90nxU13WfiO0kYkPuk2CcixsMIrMu5yGoFia cIKuSSu35zVlKnFv8LLlRv22tLauzz8RXVN67EHg= Date: Mon, 06 Apr 2020 20:08:55 -0700 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, jbi.octave@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 093/166] fs/proc/inode.c: annotate close_pdeo() for sparse Message-ID: <20200407030855.k7UikmtKV%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jules Irenge Subject: fs/proc/inode.c: annotate close_pdeo() for sparse Fix sparse locking imbalance warning: warning: context imbalance in close_pdeo() - unexpected unlock Link: http://lkml.kernel.org/r/20200227201538.GA30462@avx2 Signed-off-by: Jules Irenge Signed-off-by: Alexey Dobriyan Signed-off-by: Andrew Morton --- fs/proc/inode.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/proc/inode.c~proc-annotate-close_pdeo-for-sparse +++ a/fs/proc/inode.c @@ -202,6 +202,7 @@ static void unuse_pde(struct proc_dir_en /* pde is locked on entry, unlocked on exit */ static void close_pdeo(struct proc_dir_entry *pde, struct pde_opener *pdeo) + __releases(&pde->pde_unload_lock) { /* * close() (proc_reg_release()) can't delete an entry and proceed: _