From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70533C2BA80 for ; Tue, 7 Apr 2020 03:08:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3661720801 for ; Tue, 7 Apr 2020 03:08:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dr410PS5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3661720801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB4508E0058; Mon, 6 Apr 2020 23:08:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC3ED8E0001; Mon, 6 Apr 2020 23:08:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDCA08E0058; Mon, 6 Apr 2020 23:08:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 9D0C28E0001 for ; Mon, 6 Apr 2020 23:08:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 652F0181AEF31 for ; Tue, 7 Apr 2020 03:08:26 +0000 (UTC) X-FDA: 76679575812.30.waves63_83dd33899f649 X-HE-Tag: waves63_83dd33899f649 X-Filterd-Recvd-Size: 2431 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:08:26 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FB5320801; Tue, 7 Apr 2020 03:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228905; bh=xjJ9+4jECwNbqruA8r54GZYxA3es0d81jT1tFzeTN7M=; h=Date:From:To:Subject:In-Reply-To:From; b=dr410PS5+9Fq2JUbwguOuZs4tdfaRm7o4RZ422rmxdXZEvbSAxMzOc77kwWa4JqcC WmAgMkkmuIevP4buhysmbQgI2KzfRHDbVDTHIWlHqUsPX+hWJLSNZoaDPrhK9qZDEA IZLKBZ+lIzHWWVP21hvC4ScUvM+apl/dSlyV2n7s= Date: Mon, 06 Apr 2020 20:08:24 -0700 From: Andrew Morton To: akpm@linux-foundation.org, jbi.octave@gmail.com, linux-mm@kvack.org, minchan@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 083/166] mm/zsmalloc: add missing annotation for migrate_read_unlock() Message-ID: <20200407030824.LLdWpa9bU%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jules Irenge Subject: mm/zsmalloc: add missing annotation for migrate_read_unlock() Sparse reports a warning at migrate_read_unlock()() warning: context imbalance in migrate_read_unlock() - unexpected unlock The root cause is the missing annotation at migrate_read_unlock() Add the missing __releases(&zspage->lock) annotation Link: http://lkml.kernel.org/r/20200214204741.94112-12-jbi.octave@gmail.com Signed-off-by: Jules Irenge Acked-by: Minchan Kim Signed-off-by: Andrew Morton --- mm/zsmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/zsmalloc.c~mm-zsmalloc-add-missing-annotation-for-migrate_read_unlock +++ a/mm/zsmalloc.c @@ -1838,7 +1838,7 @@ static void migrate_read_lock(struct zsp read_lock(&zspage->lock); } -static void migrate_read_unlock(struct zspage *zspage) +static void migrate_read_unlock(struct zspage *zspage) __releases(&zspage->lock) { read_unlock(&zspage->lock); } _