From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F13EC2BA80 for ; Tue, 7 Apr 2020 03:08:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 359FA20801 for ; Tue, 7 Apr 2020 03:08:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bb+tcgbD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 359FA20801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D65A68E0056; Mon, 6 Apr 2020 23:08:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D11C08E0001; Mon, 6 Apr 2020 23:08:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7068E0056; Mon, 6 Apr 2020 23:08:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 9B1AA8E0001 for ; Mon, 6 Apr 2020 23:08:20 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5B6C999BE for ; Tue, 7 Apr 2020 03:08:20 +0000 (UTC) X-FDA: 76679575560.18.snow60_82fa8b63d5041 X-HE-Tag: snow60_82fa8b63d5041 X-Filterd-Recvd-Size: 2276 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:08:19 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3262220801; Tue, 7 Apr 2020 03:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228899; bh=Hg8+Sh9DwecPg7s0hKGM9o5bUrsQ+w7Jv04Hwdh8BSc=; h=Date:From:To:Subject:In-Reply-To:From; b=bb+tcgbDwzn0Pvi7bgLIc1wUBmPZEo8/nw8ol48fG9Lf/4X0JG99C7kej1xdKHdLv CsT9CbBXZkxYF6ZyszPKChO1oTfaRsT44IkoEJB2lnWFVXDRycXLNzMSKZWCw7FHu9 Cuz90Qbe92bUX5A/wP892vZGryRnMUPlfVqCaoA0= Date: Mon, 06 Apr 2020 20:08:18 -0700 From: Andrew Morton To: akpm@linux-foundation.org, jbi.octave@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 081/166] mm/slub: add missing annotation for put_map() Message-ID: <20200407030818.1tudKUU19%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jules Irenge Subject: mm/slub: add missing annotation for put_map() Sparse reports a warning at put_map()() warning: context imbalance in put_map() - unexpected unlock The root cause is the missing annotation at put_map() Add the missing __releases(&object_map_lock) annotation Link: http://lkml.kernel.org/r/20200214204741.94112-10-jbi.octave@gmail.com Signed-off-by: Jules Irenge Signed-off-by: Andrew Morton --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/slub.c~mm-slub-add-missing-annotation-for-put_map +++ a/mm/slub.c @@ -466,7 +466,7 @@ static unsigned long *get_map(struct kme return object_map; } -static void put_map(unsigned long *map) +static void put_map(unsigned long *map) __releases(&object_map_lock) { VM_BUG_ON(map != object_map); lockdep_assert_held(&object_map_lock); _