From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FCFC2BA1A for ; Tue, 7 Apr 2020 03:08:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 48EE220801 for ; Tue, 7 Apr 2020 03:08:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qf9WZkZ1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48EE220801 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC1A38E0054; Mon, 6 Apr 2020 23:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4BA68E0001; Mon, 6 Apr 2020 23:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D17FD8E0054; Mon, 6 Apr 2020 23:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id A220F8E0001 for ; Mon, 6 Apr 2020 23:08:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6C99C181AEF39 for ; Tue, 7 Apr 2020 03:08:14 +0000 (UTC) X-FDA: 76679575308.01.sand56_821d674a2ae16 X-HE-Tag: sand56_821d674a2ae16 X-Filterd-Recvd-Size: 2272 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:08:14 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3ADF520801; Tue, 7 Apr 2020 03:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228893; bh=lBJsRfaw6KqXabdNJa/KnBvxdMa3TogwdriWGyhS6eI=; h=Date:From:To:Subject:In-Reply-To:From; b=Qf9WZkZ1JS2bLZ9MXxb4Aaekh1mhwvXT8roxtIVJk6QoPqgijyLyaBaCg6u8SDQ8N yKF4/FU8jAfyerXLHrleO1AUsdDXg+HJpKsY7V0EaERS5q3mn7DYC7fCkRRt6q+Lt5 eRoRPqQrMVJ0WGyQFM6/NItDAW+zqJ9/piJU7zhE= Date: Mon, 06 Apr 2020 20:08:12 -0700 From: Andrew Morton To: akpm@linux-foundation.org, jbi.octave@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 079/166] mm/mempolicy: add missing annotation for queue_pages_pmd() Message-ID: <20200407030812.Fdr-ZBRAj%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jules Irenge Subject: mm/mempolicy: add missing annotation for queue_pages_pmd() Sparse reports a warning at queue_pages_pmd() context imbalance in queue_pages_pmd() - unexpected unlock The root cause is the missing annotation at queue_pages_pmd() Add the missing __releases(ptl) Link: http://lkml.kernel.org/r/20200214204741.94112-8-jbi.octave@gmail.com Signed-off-by: Jules Irenge Signed-off-by: Andrew Morton --- mm/mempolicy.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/mempolicy.c~mm-mempolicy-add-missing-annotation-for-queue_pages_pmd +++ a/mm/mempolicy.c @@ -442,6 +442,7 @@ static inline bool queue_pages_required( */ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr, unsigned long end, struct mm_walk *walk) + __releases(ptl) { int ret = 0; struct page *page; _