From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794F7C2BABC for ; Tue, 7 Apr 2020 03:08:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F62120936 for ; Tue, 7 Apr 2020 03:08:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="B5hERFto" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F62120936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E9B208E0052; Mon, 6 Apr 2020 23:08:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4A498E0001; Mon, 6 Apr 2020 23:08:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3DA88E0052; Mon, 6 Apr 2020 23:08:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B71D18E0001 for ; Mon, 6 Apr 2020 23:08:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7B4C3181AEF39 for ; Tue, 7 Apr 2020 03:08:08 +0000 (UTC) X-FDA: 76679575056.13.flesh88_8141b0a070028 X-HE-Tag: flesh88_8141b0a070028 X-Filterd-Recvd-Size: 2385 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:08:08 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48827214DB; Tue, 7 Apr 2020 03:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228887; bh=O4b1xW4RsyVD0v9mg3d8R2UgVoXkDhqS2n16Y5Pl+5o=; h=Date:From:To:Subject:In-Reply-To:From; b=B5hERFtoDlnBL5JV4RDR8GdoA5lKwzOVnYpAdNhNCPdqm6ZqSUMjgM2dUFtVAg5Re LOwk45/bCL5xddTKowL1FUTU8WpKvy4XHXX844OdxntI1iavuG8TqQLMYu9ey2KHcT fJJ2wc1TKsgoP5u2FuvlP9fCChov0AGn/N8sWthE= Date: Mon, 06 Apr 2020 20:08:06 -0700 From: Andrew Morton To: akpm@linux-foundation.org, jbi.octave@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 077/166] mm/compaction: add missing annotation for compact_lock_irqsave Message-ID: <20200407030806.7koAVNn-w%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jules Irenge Subject: mm/compaction: add missing annotation for compact_lock_irqsave Sparse reports a warning at compact_lock_irqsave() warning: context imbalance in compact_lock_irqsave() - wrong count at exit The root cause is the missing annotation at compact_lock_irqsave() Add the missing __acquires(lock) annotation. Link: http://lkml.kernel.org/r/20200214204741.94112-6-jbi.octave@gmail.com Signed-off-by: Jules Irenge Signed-off-by: Andrew Morton --- mm/compaction.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/compaction.c~mm-compaction-add-missing-annotation-for-compact_lock_irqsave +++ a/mm/compaction.c @@ -481,6 +481,7 @@ static bool test_and_set_skip(struct com */ static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, struct compact_control *cc) + __acquires(lock) { /* Track if the lock is contended in async mode */ if (cc->mode == MIGRATE_ASYNC && !cc->contended) { _