From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05635C2BA80 for ; Tue, 7 Apr 2020 03:06:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BBDFF208FE for ; Tue, 7 Apr 2020 03:06:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dGhyK6UF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBDFF208FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 65F9B8E003B; Mon, 6 Apr 2020 23:06:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E6AF8E0001; Mon, 6 Apr 2020 23:06:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D5F68E003B; Mon, 6 Apr 2020 23:06:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 326BD8E0001 for ; Mon, 6 Apr 2020 23:06:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EA7FF180AD807 for ; Tue, 7 Apr 2020 03:06:48 +0000 (UTC) X-FDA: 76679571696.07.sound55_75aef2920e01a X-HE-Tag: sound55_75aef2920e01a X-Filterd-Recvd-Size: 2919 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:06:48 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87EEB214DB; Tue, 7 Apr 2020 03:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228807; bh=/ZIsFTBI/nyscG63/irkpvBqNVgwtuTcpRvqiTXi7KQ=; h=Date:From:To:Subject:In-Reply-To:From; b=dGhyK6UFkRRfuFGayrD1xZAzq4qmINJ2rTccVlTRxOsLkvreDTZtylsUPWGWLxfeE j01ra2VYi29I+PDFL6i23uzHOBHg/cWa8VCtE/SZipWRlLXQZAuppy3P1jPRpp5MAI cBhmTOVDUnMx9nwW2GPwGRjmeAwYl5B/fwwRK+Q4= Date: Mon, 06 Apr 2020 20:06:47 -0700 From: Andrew Morton To: akpm@linux-foundation.org, anshuman.khandual@arm.com, dan.j.williams@intel.com, david@redhat.com, gregkh@linuxfoundation.org, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, pasha.tatashin@soleen.com, rafael@kernel.org, torvalds@linux-foundation.org Subject: [patch 054/166] mm/page_ext.c: drop pfn_present() check when onlining Message-ID: <20200407030647.t300q4oF3%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: David Hildenbrand Subject: mm/page_ext.c: drop pfn_present() check when onlining Since commit c5e79ef561b0 ("mm/memory_hotplug.c: don't allow to online/offline memory blocks with holes") we disallow to offline any memory with holes. As all boot memory is online and hotplugged memory cannot contain holes, we never online memory with holes. This present check can be dropped. Link: http://lkml.kernel.org/r/20200127110424.5757-4-david@redhat.com Signed-off-by: David Hildenbrand Cc: Michal Hocko Cc: Anshuman Khandual Cc: Dan Williams Cc: Greg Kroah-Hartman Cc: Pavel Tatashin Cc: "Rafael J. Wysocki" Signed-off-by: Andrew Morton --- mm/page_ext.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/mm/page_ext.c~mm-page_extc-drop-pfn_present-check-when-onlining +++ a/mm/page_ext.c @@ -303,11 +303,8 @@ static int __meminit online_page_ext(uns VM_BUG_ON(!node_state(nid, N_ONLINE)); } - for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) { - if (!pfn_in_present_section(pfn)) - continue; + for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) fail = init_section_page_ext(pfn, nid); - } if (!fail) return 0; _