From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEFF7C2BA80 for ; Tue, 7 Apr 2020 03:04:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70A7320936 for ; Tue, 7 Apr 2020 03:04:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="m+rdqtPe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70A7320936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21DD98E0018; Mon, 6 Apr 2020 23:04:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 180548E0001; Mon, 6 Apr 2020 23:04:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 094CE8E0018; Mon, 6 Apr 2020 23:04:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id DEEC58E0001 for ; Mon, 6 Apr 2020 23:04:17 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A58B5180AD806 for ; Tue, 7 Apr 2020 03:04:17 +0000 (UTC) X-FDA: 76679565354.21.earth95_5fa9b4803aa23 X-HE-Tag: earth95_5fa9b4803aa23 X-Filterd-Recvd-Size: 2888 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 03:04:17 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 396B5208FE; Tue, 7 Apr 2020 03:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586228656; bh=J9gkMM7Q1Cko1hNU3HBisyEYNxV/HEdr9hJvF0w/8pw=; h=Date:From:To:Subject:In-Reply-To:From; b=m+rdqtPeWeY/0apUaoofeYDvy2SLkwD1I9rNPP2lfbw9RQSTDGIRmsew1LHUxMBwG 6VIE3ijH9BnO+wGguY0YJn4Gr4LzTHDuDAeDAOLxqAXNeGk7FPBzNBjwfev5PBQbZ4 IVJFgjUIBVP64BJi3Ybr3bpf2hmE3MrqJBAB4AFY= Date: Mon, 06 Apr 2020 20:04:15 -0700 From: Andrew Morton To: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, richardw.yang@linux.intel.com, torvalds@linux-foundation.org Subject: [patch 014/166] mm/migrate.c: check pagelist in move_pages_and_store_status() Message-ID: <20200407030415.P_Ho3gLkV%akpm@linux-foundation.org> In-Reply-To: <20200406200254.a69ebd9e08c4074e41ddebaf@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang Subject: mm/migrate.c: check pagelist in move_pages_and_store_status() When pagelist is empty, it is not necessary to do the move and store. Also it consolidate the empty list check in one place. Link: http://lkml.kernel.org/r/20200214003017.25558-4-richardw.yang@linux.intel.com Signed-off-by: Wei Yang Acked-by: Michal Hocko Reviewed-by: David Hildenbrand Signed-off-by: Andrew Morton --- mm/migrate.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/mm/migrate.c~mm-migratec-check-pagelist-in-move_pages_and_store_status +++ a/mm/migrate.c @@ -1518,9 +1518,6 @@ static int do_move_pages_to_node(struct { int err; - if (list_empty(pagelist)) - return 0; - err = migrate_pages(pagelist, alloc_new_node_page, NULL, node, MIGRATE_SYNC, MR_SYSCALL); if (err) @@ -1608,6 +1605,9 @@ static int move_pages_and_store_status(s { int err; + if (list_empty(pagelist)) + return 0; + err = do_move_pages_to_node(mm, pagelist, node); if (err) { /* @@ -1705,9 +1705,6 @@ static int do_pages_move(struct mm_struc current_node = NUMA_NO_NODE; } out_flush: - if (list_empty(&pagelist)) - return err; - /* Make sure we do not overwrite the existing error */ err1 = move_pages_and_store_status(mm, current_node, &pagelist, status, start, i, nr_pages); _