From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B8BC2BA1A for ; Mon, 6 Apr 2020 20:00:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D8F420748 for ; Mon, 6 Apr 2020 20:00:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="nPqNqzLG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D8F420748 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C32648E0005; Mon, 6 Apr 2020 16:00:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2978E0001; Mon, 6 Apr 2020 16:00:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8448E0005; Mon, 6 Apr 2020 16:00:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 9413E8E0001 for ; Mon, 6 Apr 2020 16:00:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4DA091867 for ; Mon, 6 Apr 2020 20:00:23 +0000 (UTC) X-FDA: 76678497126.20.work42_20732afcf703e X-HE-Tag: work42_20732afcf703e X-Filterd-Recvd-Size: 2707 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 20:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kqzeiCoDoOQ3qJWZZp8tCPOkIcKx/AKK5dlo5OJFP3g=; b=nPqNqzLGmw3vq6hNA7s5ptUQr3 uWDbaBu34UYbHaVwjlyp6TjveDEcBGTJ6jCF8Vc4JBtQJhdLPqa70GxSQFYeRgktCVTUcitQp1zmd BaXdpg300jsfEkWPpQyA62uY2fVEttWsDdZWLMFH40+PEPNsrZTqiqx4PxJ+Dzdy3VXX81MoTmC7f S9SUYQJsDdZx5mOAUU97DMKDEOZIuO0COqNxU9sv3j6iosr3mbizsk2MJ/q6Ovta8fb1LiomLnzro S6DP+2ApMWRMuwmVZJiZLpMGFrWzVcndIMXNqtiKijryle8Daut1hUUw7yIVCtAX5oFQWeS2+QMcO MeG8g8vA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLXuq-0006Gj-Nk; Mon, 06 Apr 2020 20:00:16 +0000 Date: Mon, 6 Apr 2020 13:00:16 -0700 From: Matthew Wilcox To: Waiman Long Cc: Andrew Morton , David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , linux-mm@kvack.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Joe Perches , David Rientjes Subject: Re: [PATCH v2] mm: Add kvfree_sensitive() for freeing sensitive data objects Message-ID: <20200406200016.GJ21484@bombadil.infradead.org> References: <20200406185827.22249-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406185827.22249-1-longman@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 02:58:27PM -0400, Waiman Long wrote: > +/** > + * kvfree_sensitive - free a data object containing sensitive information > + * @addr - address of the data object to be freed > + * @len - length of the data object Did you try building this with W=1? I believe this is incorrect kerneldoc. It should be @addr: and @len: Also, it reads better in the htmldocs if you capitalise the first letter of each sentence and finish with a full stop. > @@ -914,7 +911,7 @@ long keyctl_read_key(key_serial_t keyid, char __user *buffer, size_t buflen) > */ > if (ret > key_data_len) { > if (unlikely(key_data)) > - __kvzfree(key_data, key_data_len); > + kvfree_sensitive(key_data, key_data_len); I'd drop the test of key_data here.