From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BA6C2BA17 for ; Mon, 6 Apr 2020 17:26:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C438D24A01 for ; Mon, 6 Apr 2020 17:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XD9ULJvK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C438D24A01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 729778E0053; Mon, 6 Apr 2020 13:26:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D8C68E000D; Mon, 6 Apr 2020 13:26:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C7A28E0053; Mon, 6 Apr 2020 13:26:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 4364F8E000D for ; Mon, 6 Apr 2020 13:26:27 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F0431801909C for ; Mon, 6 Apr 2020 17:26:26 +0000 (UTC) X-FDA: 76678109172.21.body36_8f94d7804b84b X-HE-Tag: body36_8f94d7804b84b X-Filterd-Recvd-Size: 2884 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 17:26:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=q9CGTy2dc0MrY9cMsMeMUAWfqIRDO4jAB1O3OBknZB8=; b=XD9ULJvK1A0c/SvJDtNXABwnkO q6V6WTCsRVQMGZAOQJtEG1yW9Cj1QbMiEvHrNlGL50EXlc8TJxSiSyhSNpg3vAzNDiPdfp50jwilf OwG/Tm7zSYHrJybEWgPCyim+srezIdWLQ7uydH+6stOg5kDI6GS3PTn6hR2M8hMA1y97s42CIdCfR 4Zbj1JJIRt7d0f9QEtdxrnHvwcl3kckU7w8uKXJlSsgcd2Pk5j+I9/gwtlSBDO9FHgZAcO4S2my/j oVp+HPogBzxcjgvW12kNo8Uowg9CYVkvIVPGG181fSAXpUXZYZxeAuB0QWTEqqZt0UGnayxTDaXdH E4w+vY+w==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLVVq-000608-H7; Mon, 06 Apr 2020 17:26:18 +0000 Date: Mon, 6 Apr 2020 10:26:18 -0700 From: Matthew Wilcox To: Joe Perches Cc: Linus Torvalds , David Howells , Waiman Long , Andrew Morton , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Linux-MM , keyrings@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] mm: Add kvfree_sensitive() for freeing sensitive data objects Message-ID: <20200406172618.GH21484@bombadil.infradead.org> References: <20200406023700.1367-1-longman@redhat.com> <319765.1586188840@warthog.procyon.org.uk> <7eb36a794df38c885689085618a8a4ff9df3dd2c.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7eb36a794df38c885689085618a8a4ff9df3dd2c.camel@perches.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 10:20:24AM -0700, Joe Perches wrote: > > You really don't seem to get the whole "kzfree() has absolutely > > _nothing_ to do with kzalloc() apart from a dubious implementation > > details". > > API function naming symmetry is good. It's good when there's actual symmetry between the two functions. kvalloc() memory should be freed with kvfree(). That makes sense. kzalloc() memory should not normally be freed with kzfree(). The symmetry hurts you, not helps you.