From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0032C2BA1E for ; Mon, 6 Apr 2020 17:08:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8BBEB249BC for ; Mon, 6 Apr 2020 17:08:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BBEB249BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22C658E004D; Mon, 6 Apr 2020 13:08:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE908E000D; Mon, 6 Apr 2020 13:08:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A5718E004D; Mon, 6 Apr 2020 13:08:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id E51388E000D for ; Mon, 6 Apr 2020 13:08:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A6E5340D7 for ; Mon, 6 Apr 2020 17:08:25 +0000 (UTC) X-FDA: 76678063770.09.rod23_83bf43fb9ec2b X-HE-Tag: rod23_83bf43fb9ec2b X-Filterd-Recvd-Size: 5094 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 17:08:25 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id f206so7839240pfa.10 for ; Mon, 06 Apr 2020 10:08:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zaXeCIKa/04xAB8MmodjJgT7JeJhzRdAxQcRW/0TGww=; b=XCJZtVgrFctlpkjmcePB6rqe7RK2EDi0Dhfc8/SKz2aL9RXCudFhgDibuqfmaQPhWu KEkX2Sr1V5cqdDKmuAFJli3Z6kRrtVRJrJb8z/Q2TlFRZdzo84pudDB9MT61HxisPhHp 1plJqEfIkTM+3BDf1stXXoe4Fx1/bh5MnHRXqPbppSMiieswVdnHBsgLDCLiQG/XI9nv WgZo7iTEHig4/+rpBT6BX4k09ad6frLA2Ls4N1ElIxCoK9Qc+KpJ8tq1nGheOL7Bf5FH QICczUO5StbjLI4qoimTOCvjxuFdAG0Epm6VicJ3XAybHKZR9sStQGp8CN8cKIDYAsj/ TWNg== X-Gm-Message-State: AGi0PubpKY9JGkldJGu3GR7BkNv4JTobw+8VD1KKE7U8+NDzHrQ5QKkr Lv0Z+s/+zGTGpYPYGA2giQs= X-Google-Smtp-Source: APiQypJ9XkDYt38q2mJtSLza4PVdlKnHbUCkqeIRzEJCfTivTo/drR4DFb5YNsn2t8LPMWqmhBrWTg== X-Received: by 2002:a62:76c3:: with SMTP id r186mr408779pfc.303.1586192904248; Mon, 06 Apr 2020 10:08:24 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id o192sm8883072pfg.196.2020.04.06.10.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 10:08:23 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 5269C40246; Mon, 6 Apr 2020 17:08:22 +0000 (UTC) Date: Mon, 6 Apr 2020 17:08:22 +0000 From: Luis Chamberlain To: Kees Cook Cc: Vlastimil Babka , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <20200406170822.GE11244@42.do-not-panic.com> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> <20200330224422.GX11244@42.do-not-panic.com> <287ac6ae-a898-3e68-c7d8-4c1d17a40db9@suse.cz> <20200402160442.GA11244@42.do-not-panic.com> <202004021017.3A23B759@keescook> <20200402205932.GM11244@42.do-not-panic.com> <202004031654.C4389A04EF@keescook> <20200406140836.GA11244@42.do-not-panic.com> <202004060856.6BC17C5C99@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202004060856.6BC17C5C99@keescook> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 08:58:50AM -0700, Kees Cook wrote: > On Mon, Apr 06, 2020 at 02:08:36PM +0000, Luis Chamberlain wrote: > > > Yes. Doing an internal extension isn't testing the actual code. > > > > But it would. > > > > [...] > > > I don't think anything is needed for this series. It can be boot tested > > > manually. > > > > Why test it manually when it could be tested automatically with a new kconfig? > > So, my impression is that adding code to the internals to test the > internals isn't a valid test (or at least makes it fragile) because the > test would depend on the changes to the internals (or at least depend on > non-default non-production CONFIGs). The *internal* aspect here is an extension to boot params under a kconfig which would simply append to it, as if the user would have added some more params. Since we already have test sysctl params the only one we'd need to add on the test driver would be a dummy one which tests the alias, on the second patch. We should have enough sysctls to already test dummy values. Nothing else would be needed as the sysctl test driver would just need to test that the values expected when this is enabled is set. > Can you send a patch for what you think this should look like? Perhaps > I'm not correctly imagining what you're describing? I rather get the person involved in the changes to do the testing so as they're the ones designing the feature. If however it is not clear what I mean I'm happy to elaborate. Vlastimil do you get what I mean? > Regardless of testing, I think this series is ready for -mm. I'm happy for it to go in provided we at least devise a follow up plan for testing. Otherwise -- like other things, it won't get done. Luis