From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058DEC2BA17 for ; Mon, 6 Apr 2020 16:42:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBE4924982 for ; Mon, 6 Apr 2020 16:42:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Tzvu4YHN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBE4924982 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 76FEF8E004A; Mon, 6 Apr 2020 12:42:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 720398E000D; Mon, 6 Apr 2020 12:42:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 636608E004A; Mon, 6 Apr 2020 12:42:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 464FD8E000D for ; Mon, 6 Apr 2020 12:42:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0E83C80186DC for ; Mon, 6 Apr 2020 16:42:56 +0000 (UTC) X-FDA: 76677999552.11.mass20_36b0a96588b36 X-HE-Tag: mass20_36b0a96588b36 X-Filterd-Recvd-Size: 2043 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 16:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ued/Cv22Lz7ZfPMDt+JQHBrX0mUy2vRIxm57cM+yYBg=; b=Tzvu4YHNSTPPNunhg0QcaTmNwe EDQwJrn0aXJV0hjVycHdUj7nvcAaQ/8ahb+ocGCfZUaGxqoizQzVRY/x3A4DkiuyKQlDFCqEJfAoW EnMIWZUkqlTZGzD4TbiGW90wv4sdDLN9/QIpU1jpdIeS/m7bf7mkfDFFqLR1EIVa5LhnlSd6/6yeZ li4pxWCkdvPewUstZt2eT7cOHURm9gm/hBrc9VWbsOspr+Y8MG6jbpNq5yqWj49KveR1voFapUTFO VGPtIMpNhThzjt6MknFBFrTNtpHUG0lPQoxpAG7FZCafAgfjmCkfeUxH/xaEH2ObVL1X4Q7jecimy vXi44ttw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLUpn-00054z-3s; Mon, 06 Apr 2020 16:42:51 +0000 Date: Mon, 6 Apr 2020 09:42:51 -0700 From: Matthew Wilcox To: Yafang Shao Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm, memcg: fix error return value of mem_cgroup_css_alloc() Message-ID: <20200406164251.GE21484@bombadil.infradead.org> References: <1586188134-17038-1-git-send-email-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1586188134-17038-1-git-send-email-laoar.shao@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 11:48:54PM +0800, Yafang Shao wrote: > @@ -2717,8 +2717,12 @@ static int memcg_alloc_cache_id(void) > > id = ida_simple_get(&memcg_cache_ida, > 0, MEMCG_CACHES_MAX_SIZE, GFP_KERNEL); > - if (id < 0) > + if (id < 0) { > + if (id == -ENOSPC) > + id = -EBUSY; > + > return id; > + } This seems more complex than my original suggestion?