From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E62BC2BA1E for ; Mon, 6 Apr 2020 18:29:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0473D20731 for ; Mon, 6 Apr 2020 18:29:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0473D20731 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stgolabs.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 96B0D8E000F; Mon, 6 Apr 2020 14:29:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91AB38E000D; Mon, 6 Apr 2020 14:29:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857A38E000F; Mon, 6 Apr 2020 14:29:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0082.hostedemail.com [216.40.44.82]) by kanga.kvack.org (Postfix) with ESMTP id 6F7B38E000D for ; Mon, 6 Apr 2020 14:29:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 32716181AC1F5 for ; Mon, 6 Apr 2020 18:29:58 +0000 (UTC) X-FDA: 76678269276.23.death97_741b02a1fb427 X-HE-Tag: death97_741b02a1fb427 X-Filterd-Recvd-Size: 2608 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 18:29:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 91434AF85; Mon, 6 Apr 2020 18:29:54 +0000 (UTC) Date: Mon, 6 Apr 2020 09:03:56 -0700 From: Davidlohr Bueso To: Laurent Dufour Cc: Michel Lespinasse , Andrew Morton , linux-mm , LKML , Peter Zijlstra , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , David Rientjes , Hugh Dickins , Ying Han Subject: Re: [PATCH 8/8] mmap locking API: rename mmap_sem to mmap_lock Message-ID: <20200406160356.py26by67dhprte5d@linux-p48b> Mail-Followup-To: Laurent Dufour , Michel Lespinasse , Andrew Morton , linux-mm , LKML , Peter Zijlstra , Vlastimil Babka , Matthew Wilcox , Liam Howlett , Jerome Glisse , David Rientjes , Hugh Dickins , Ying Han References: <20200326070236.235835-1-walken@google.com> <20200326070236.235835-9-walken@google.com> <4eaa33a1-8144-253e-ac99-eeb354b6f871@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <4eaa33a1-8144-253e-ac99-eeb354b6f871@linux.ibm.com> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 06 Apr 2020, Laurent Dufour wrote: >Le 26/03/2020 =E0 08:02, Michel Lespinasse a =E9crit=A0: >>Rename the mmap_sem field to mmap_lock. Any new uses of this lock >>should now go through the new mmap locking api. The mmap_lock is >>still implemented as a rwsem, though this could change in the future. > >Since you don't change the type of the mmap_sem, it's still a=20 >semaphore, I don't think mmap_lock is a good name. This is not a lock. Well a semaphore is still a kind of lock. I think the naming in this patch is good and generic enough. Thanks, Davidlohr