From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 698F7C2BA19 for ; Mon, 6 Apr 2020 14:40:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1BADC2072F for ; Mon, 6 Apr 2020 14:40:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DU7X6AEW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BADC2072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 950788E0033; Mon, 6 Apr 2020 10:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 901D48E000D; Mon, 6 Apr 2020 10:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF7A8E0033; Mon, 6 Apr 2020 10:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 655258E000D for ; Mon, 6 Apr 2020 10:40:02 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 242D7181AEF3E for ; Mon, 6 Apr 2020 14:40:02 +0000 (UTC) X-FDA: 76677689844.16.bears57_416428d3b0d X-HE-Tag: bears57_416428d3b0d X-Filterd-Recvd-Size: 2443 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 14:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3AZQaHvV6HY7ZEgP+flSvFuWBowXtcYeUgk6HyT0388=; b=DU7X6AEW4T91imZK6UpDtwkFoc AOtXF/9J/iSX/VJH8KlWNJUJdhnL2vOr3RilPx/Y2HzGNpxfgw8o4cQB62sJQcwqmoBG+uGRgaoud txDnk7BS96aR2TOZYWccnZIpi2eak+eXOKWNluYvUEVyU1d3/5+cxYsg/M7XGZQ8dKVpxCOwdjg28 4Vmm0fyCcNd+hjGT4UJbvNOiT/UUE3XBbwR7e7onP/JZUPLbrYMSQBLfZDNftRYj9hvpfk3xS0McY aVmmJgTdDskhFp3YXT/zf5LxXWZyI4/CE08Jgul3AZwYlGklZrhEJLtxLn9ck1ACrkJsT0MYlxyVA vvi8bTMA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLSul-0005uy-I5; Mon, 06 Apr 2020 14:39:51 +0000 Date: Mon, 6 Apr 2020 07:39:51 -0700 From: Matthew Wilcox To: Waiman Long Cc: David Rientjes , Andrew Morton , David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , linux-mm@kvack.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH] mm: Add kvfree_sensitive() for freeing sensitive data objects Message-ID: <20200406143951.GD21484@bombadil.infradead.org> References: <20200406023700.1367-1-longman@redhat.com> <3f6658e5-0082-7759-1d08-eda9cb3eba2f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f6658e5-0082-7759-1d08-eda9cb3eba2f@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 10:36:07AM -0400, Waiman Long wrote: > ZERO_OR_NULL_PTR is defined in slab.h. Using it may cause some header > file dependency problem. To guard against the possibility of 0-length > allocation request, how about just Why is all the kvalloc/kvfree crap in mm.h to begin with? slab.h is a more sensible place to put it. I had a patch to do that once, but I think it went stale before I posted it.