From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1063CC2BA19 for ; Mon, 6 Apr 2020 14:11:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA16D23A54 for ; Mon, 6 Apr 2020 14:11:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="rdQuD4cm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA16D23A54 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CE2C8E002D; Mon, 6 Apr 2020 10:11:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67E4E8E000D; Mon, 6 Apr 2020 10:11:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BB1F8E002D; Mon, 6 Apr 2020 10:11:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0076.hostedemail.com [216.40.44.76]) by kanga.kvack.org (Postfix) with ESMTP id 416158E000D for ; Mon, 6 Apr 2020 10:11:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F37462C81 for ; Mon, 6 Apr 2020 14:11:56 +0000 (UTC) X-FDA: 76677619032.01.pet16_2e1626231de13 X-HE-Tag: pet16_2e1626231de13 X-Filterd-Recvd-Size: 2432 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 14:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rE/1L96r4MYMwJsiBEPB31en815DXzfABRkosRhzWLU=; b=rdQuD4cmFzdEkeAWsPle8BY/Dv QhbAO8yeHEWTovyjYWM4YRGhF++ycjMFlFJT6PbHhz7HPtoufjw1lbt9WDr+99Kg4M7wtk3B6RLPG 6beRl5SC9Xc9+xnpFB7w8v0shUV6Q0DGn+0jMeU3Od+BA4M6YGd7kKJ8TeeuMbg8DY9Ne3EBs0kOJ vgSGb3xcKgM8Q8MsaWOnUlwK9wvu5jZRhUscIfeJZ59gY6bRJk4VOxy8xRymp3FPrUO5hehugNeIy G337bhYob45B9rKJ5VD6ovczgPl1HkWlVYCCLkDtG3qFLmKtPPKFvLVi6hJ8PMT87M7s1qMJOPqZT xjwaB6QA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLSTh-0004jq-ET; Mon, 06 Apr 2020 14:11:53 +0000 Date: Mon, 6 Apr 2020 07:11:53 -0700 From: Matthew Wilcox To: Yafang Shao Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Linux MM Subject: Re: [PATCH] mm, memcg: fix error return value of mem_cgroup_alloc() Message-ID: <20200406141153.GB21484@bombadil.infradead.org> References: <1586177647-11889-1-git-send-email-laoar.shao@gmail.com> <20200406130533.GZ21484@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 06, 2020 at 10:09:55PM +0800, Yafang Shao wrote: > What about ida_alloc_range() ? Should we correct it as well ? > > > * Return: The allocated ID, or %-ENOMEM if memory could not be allocated, > * or %-ENOSPC if there are no free IDs. > */ > int ida_alloc_range(struct ida *ida, unsigned int min, unsigned int max, > gfp_t gfp) > > If there're no free IDs, ida_alloc_range() also returns ENOSPC. Do you want to check all the callers of ida_.*alloc()?