From: Matthew Wilcox <willy@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm, memcg: fix error return value of mem_cgroup_alloc()
Date: Mon, 6 Apr 2020 07:11:53 -0700 [thread overview]
Message-ID: <20200406141153.GB21484@bombadil.infradead.org> (raw)
In-Reply-To: <CALOAHbASRnoQA6eb46x2154ssWq+r_2y-Z4kRVRt7aac9UVe4w@mail.gmail.com>
On Mon, Apr 06, 2020 at 10:09:55PM +0800, Yafang Shao wrote:
> What about ida_alloc_range() ? Should we correct it as well ?
>
>
> * Return: The allocated ID, or %-ENOMEM if memory could not be allocated,
> * or %-ENOSPC if there are no free IDs.
> */
> int ida_alloc_range(struct ida *ida, unsigned int min, unsigned int max,
> gfp_t gfp)
>
> If there're no free IDs, ida_alloc_range() also returns ENOSPC.
Do you want to check all the callers of ida_.*alloc()?
next prev parent reply other threads:[~2020-04-06 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 12:54 Yafang Shao
2020-04-06 13:05 ` Matthew Wilcox
2020-04-06 13:30 ` Yafang Shao
2020-04-06 14:09 ` Yafang Shao
2020-04-06 14:11 ` Matthew Wilcox [this message]
2020-04-06 14:16 ` Yafang Shao
2020-04-06 14:25 ` Matthew Wilcox
2020-04-06 14:28 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406141153.GB21484@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox