From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 933AFC2BA1E for ; Mon, 6 Apr 2020 12:59:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 28A7220B1F for ; Mon, 6 Apr 2020 12:59:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L6EHQhR0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28A7220B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 976068E0012; Mon, 6 Apr 2020 08:59:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 927428E000D; Mon, 6 Apr 2020 08:59:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 815A98E0012; Mon, 6 Apr 2020 08:59:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 6B9A48E000D for ; Mon, 6 Apr 2020 08:59:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 258B0801A4FC for ; Mon, 6 Apr 2020 12:59:38 +0000 (UTC) X-FDA: 76677436836.26.leaf28_8e4b012626236 X-HE-Tag: leaf28_8e4b012626236 X-Filterd-Recvd-Size: 3861 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Apr 2020 12:59:37 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id b1so14583622ljp.3 for ; Mon, 06 Apr 2020 05:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=klGEPOVDqn0bHzD1zMNsz5U+EKZKtsRBPVdGZkiUwzY=; b=L6EHQhR08UEDQVjIcRRQqpRuNU0ry8dFIxvNdiDx7xDskMUUR9Qij89a7fsB9R8P7c FNLySfsbN7kjbhIjoqxCQWkff9+tSezheTYzLGoyTc787WJvfO+zq7beUB8jcvIH6jtD b/Ju9d6IirvKLABMqN28hvLqxmmZdPdpKaNPzQ3C3eJsEsnsW3V/ny/DdlLq1ng9y9ME yxKZpt2sX44AEk3GjalOij6sT1SjoyhFTCz6zy+znvugFEM7l2xN7kQOlhM6PM3zQbfe WSd9k6Y/u0ADE004ob5NJ7j/qxLxw13ans4dEp/rcslIJkU5nXjdZdGI0H6f0fTc6Em4 GZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=klGEPOVDqn0bHzD1zMNsz5U+EKZKtsRBPVdGZkiUwzY=; b=KYR+hXHv02H7L+VJvUCb/8DFhXa431LpJfdPt/y3gfvarInl4cl5J+Nt97rkbV0IXI bsvovj7tKS1tX9v+ueLJ3nCbpaRIZbRRibtCaquSDGSdLvmy+wS3k1o7amcpKIYmfpNB zEfvRe3PGK4QLLgOoAk05air9/RJLF3kfndenLKsOSGGphNeNisAhieoU8EGbsxGSRRC Cjs7/hRv9W2pxBeKcYlICwoWVh2MYXwzDowKIs5aLDp+aDgbe/qV7CStXujohj0oWK1L KnIQLYWzR/jWSp8iA2FfWWuntoPuKxE/SOEl1TvwjQ1n+4dyYRMXMxmHDUZgB1nJhnhk 7QiQ== X-Gm-Message-State: AGi0Pua7bcdMUhZBLWt7u96YtKYuWXgqoffnxPy4SUQMQm61We4ePIJ8 vRMt6bPEgrvECE0qAfq3T/E= X-Google-Smtp-Source: APiQypIyvIV73lkHcnEsV82UaxQt9zdT0TXyQVEzlvxTzFOiCLsas0M8KBVZfMWG1nuc63LkYNeQXg== X-Received: by 2002:a2e:9616:: with SMTP id v22mr11512135ljh.107.1586177976108; Mon, 06 Apr 2020 05:59:36 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id t24sm8822318lfk.90.2020.04.06.05.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 05:59:35 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 6 Apr 2020 14:59:28 +0200 To: William Kucharski Cc: Uladzislau Rezki , Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm , jroedel@suse.de, Vlastimil Babka , Thomas Gleixner Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Message-ID: <20200406125928.GA23653@pc636> References: <20200404185229.GA424@pc636> <20200405172315.GA8404@pc636> <20200405192108.GA9429@pc636> <65663E36-DC60-4E6E-B6C6-3A0F6852543D@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65663E36-DC60-4E6E-B6C6-3A0F6852543D@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 05, 2020 at 02:49:13PM -0600, William Kucharski wrote: > That's fine. > > One could still argue size should be sanitized earlier when start and end > are, but it's a nit either way (though size is used before it's checked, > it's not in any way that could fail with bad results.) > Agree. Therefore i do not have a strong opinion here, so it basically depends on how to look at it :) -- Vlad Rezki