From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B13E4C2BA19 for ; Mon, 6 Apr 2020 09:18:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 40E9020787 for ; Mon, 6 Apr 2020 09:18:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E9020787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E8A0B8E000E; Mon, 6 Apr 2020 05:18:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3C7F8E000D; Mon, 6 Apr 2020 05:18:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50738E000E; Mon, 6 Apr 2020 05:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id BB4B28E000D for ; Mon, 6 Apr 2020 05:18:29 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 75B55F01D for ; Mon, 6 Apr 2020 09:18:29 +0000 (UTC) X-FDA: 76676879538.05.pig88_67038e5d5e212 X-HE-Tag: pig88_67038e5d5e212 X-Filterd-Recvd-Size: 2752 Received: from r3-25.sinamail.sina.com.cn (r3-25.sinamail.sina.com.cn [202.108.3.25]) by imf09.hostedemail.com (Postfix) with SMTP for ; Mon, 6 Apr 2020 09:18:27 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.246.227.120]) by sina.com with ESMTP id 5E8AF3DE00011376; Mon, 6 Apr 2020 17:18:24 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 41881254919326 From: Hillf Danton To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Vlastimil Babka , Mel Gorman , kernel-team@lge.com, Joonsoo Kim Subject: Re: [PATCH v5 02/10] mm/vmscan: protect the workingset on anonymous LRU Date: Mon, 6 Apr 2020 17:18:14 +0800 Message-Id: <20200406091814.17256-1-hdanton@sina.com> In-Reply-To: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Apr 2020 14:40:40 +0900 Joonsoo Kim wrote: >=20 > @@ -3093,11 +3093,10 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > if (unlikely(page !=3D swapcache && swapcache)) { > page_add_new_anon_rmap(page, vma, vmf->address, false); > mem_cgroup_commit_charge(page, memcg, false, false); > - lru_cache_add_active_or_unevictable(page, vma); > + lru_cache_add_inactive_or_unevictable(page, vma); > } else { > do_page_add_anon_rmap(page, vma, vmf->address, exclusive); > mem_cgroup_commit_charge(page, memcg, true, false); > - activate_page(page); > } > =20 > swap_free(entry); ... > @@ -996,8 +996,6 @@ static enum page_references page_check_references(s= truct page *page, > return PAGEREF_RECLAIM; > =20 > if (referenced_ptes) { > - if (PageSwapBacked(page)) > - return PAGEREF_ACTIVATE; > /* > * All mapped pages start out with page table > * references from the instantiating fault, so we need > @@ -1020,7 +1018,7 @@ static enum page_references page_check_references= (struct page *page, > /* > * Activate file-backed executable pages after first usage. > */ > - if (vm_flags & VM_EXEC) > + if ((vm_flags & VM_EXEC) && !PageSwapBacked(page)) > return PAGEREF_ACTIVATE; > =20 > return PAGEREF_KEEP; > --=20 > 2.7.4 Both changes other than s/lru_cache_add_active_or_unevictable/lru_cache_add_inactive_or_unevictab= le/ are likely worth their own seperate commits with a concise log.