From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E4BC2BA15 for ; Sun, 5 Apr 2020 19:21:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0455F20672 for ; Sun, 5 Apr 2020 19:21:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jmssw7Q4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0455F20672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8250E8E000A; Sun, 5 Apr 2020 15:21:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D4AA8E0009; Sun, 5 Apr 2020 15:21:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E9178E000A; Sun, 5 Apr 2020 15:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 577278E0009 for ; Sun, 5 Apr 2020 15:21:18 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0B1E3181AC550 for ; Sun, 5 Apr 2020 19:21:18 +0000 (UTC) X-FDA: 76674769836.28.pest35_45846e88f2255 X-HE-Tag: pest35_45846e88f2255 X-Filterd-Recvd-Size: 4653 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Sun, 5 Apr 2020 19:21:17 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id p10so12400390ljn.1 for ; Sun, 05 Apr 2020 12:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=K/gE1z0Eaezf8CdrotTqmm4GlBR/apNE6goPF1H868E=; b=jmssw7Q4C+dMb4APFNV1JCtZ50K44ipedz3O1LoSw7dkZ/AYx2iaQ3PE5R0a34M8on 4Y8ESBetYuHssrR5QDRKF006VRXj3xvYM+pK9RCUL16B1/n3/7srIiBJ3aPF21zPhyZc sKskY+Mjjopx1GOb0Yk4PGosduC7m08UgOCBYDoqcAk/+lg5ziKQ41dcnkMddZdo0hLi uVjs+xnIAvfpcPGwdUf1CdIFVgYcNjbNNWUUfvwzOsrlcT+mgxMqeUZjPkAWKgzAgcae cIF+nWm+NgjUjfg2sko8BBD0XZ8wZ3/gKvpTtQbN8EnX2UglUJq6gU1IPN8ffgxnCfd5 tADA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=K/gE1z0Eaezf8CdrotTqmm4GlBR/apNE6goPF1H868E=; b=SZ6KPh15EZslr7gCHEFAPayP+OR/xnQrlvKwfkQFqXYSpDJXDP73Rbhs8OJZgUYnci 3iXs7b5ZIsGhm7yKCUU1ZpsJHWmNIId9SU+kw8W3ZmRHddi+uVhInUs/cMJdwFIStTkX IjhrDqw+QW+tUSbtsUhj/RPxfZA9tx9Dl9j+Gs88E3QZd4net6wVmubTWbp3kz05RLvX pz2rCW0yQVPQ3BMPv4gkZTPuRLfY5YTOmCNVGY5w/iKXy+IRDdE743yJf/00hFIP/9DP 0gRnAWvUpRFtQFJ5+VUpcTNye+0J0GqyBDGjN5kHsTTFZ+CQc1Bh3S11yeK3fsl/e+zq k9KA== X-Gm-Message-State: AGi0PubnvTBtJdoZjWDFNy2khPKjQWxZ6BDjzJZebJeP0sxvlXizpqUY Veq5k9dsQotrboVY8eZITJo= X-Google-Smtp-Source: APiQypIOCgLvNUUwJVdz2ZAl6mcMp7GYpClx3bpUAGMEoGpx0nrA7xNGUNZiZxBdXzqQMU5Wq6U0hQ== X-Received: by 2002:a2e:a412:: with SMTP id p18mr10529382ljn.39.1586114476048; Sun, 05 Apr 2020 12:21:16 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id d9sm8914864ljg.39.2020.04.05.12.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2020 12:21:15 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sun, 5 Apr 2020 21:21:08 +0200 To: William Kucharski Cc: William Kucharski , Peter Zijlstra , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, jroedel@suse.de, vbabka@suse.cz, Thomas Gleixner Subject: Re: [PATCH] mm/vmalloc: Sanitize __get_vm_area() arguments Message-ID: <20200405192108.GA9429@pc636> References: <20200404185229.GA424@pc636> <20200405172315.GA8404@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200405172315.GA8404@pc636> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 05, 2020 at 07:23:15PM +0200, Uladzislau Rezki wrote: > On Sat, Apr 04, 2020 at 11:25:45PM -0600, William Kucharski wrote: > >=20 > >=20 > > > On Apr 4, 2020, at 12:52 PM, Uladzislau Rezki wr= ote: > > >=20 > > >>=20 > > >> =EF=BB=BFIs there any need to similarly sanitize =E2=80=9Csize=E2=80= =9D to assure start + size doesn=E2=80=99t go past =E2=80=9Cend?=E2=80=9D > > >>=20 > > > Why is that double check needed if all such tests are done deeper o= n stack? > >=20 > > If such tests ARE performed, then it doesn't matter to me whether it = is checked before or after, > > it just seems that nothing checks whether start + size makes some sor= t of sense with respect > > to end. > >=20 > > I admit I didn't walk through all the routines to see if such a check= would be superfluous. > >=20 > Yes, we check it: >=20 > > static __always_inline bool > is_within_this_va(struct vmap_area *va, unsigned long size, > unsigned long align, unsigned long vstart) > { > ... > return (nva_start_addr + size <=3D va->va_end); > } > >=20 Sorry, was thinking about one place showed different one. Here we go: /* Check the "vend" restriction. */ if (nva_start_addr + size > vend) return vend; -- Vlad Rezki