From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2206EC2BA15 for ; Sat, 4 Apr 2020 19:10:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D2615206F5 for ; Sat, 4 Apr 2020 19:10:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R+3xMmnL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2615206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 75B468E000B; Sat, 4 Apr 2020 15:10:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70C028E0009; Sat, 4 Apr 2020 15:10:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6210C8E000B; Sat, 4 Apr 2020 15:10:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 480BE8E0009 for ; Sat, 4 Apr 2020 15:10:15 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0318B181AEF1A for ; Sat, 4 Apr 2020 19:10:15 +0000 (UTC) X-FDA: 76671113190.28.value19_3c56cddb68003 X-HE-Tag: value19_3c56cddb68003 X-Filterd-Recvd-Size: 4846 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 4 Apr 2020 19:10:14 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id r7so10352115ljg.13 for ; Sat, 04 Apr 2020 12:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tl3rjpPzWvGvL5lEB/U94s6R20w0vWjGnxBhIo2dvKk=; b=R+3xMmnLBQT6BKGYkGzjIs2vz/gt3i1MDNgUWxP2CZUYyP/jPprxcX9sL9dxwqEJRn Q0iEfHnfH3kZ13ID8pHx0VYmACizj7+NTuycPI03Ucrz32S7EpRLH3ISv/INGQZCwbhY sjb1AGF3pgqxTlDtjqCO8Br8EPRx7Ci/tIQg+Ub271zKXvMvTgWUsEfZ+QqNMNZ5bYnZ mQUx2h9e+7VCkbFnX1IoX8FynL+0GW72qGETVQH4Im+UVITmuAqp7ZwoaSPLqlz+sWM4 CoPpVVIP/UKy4foUp4BK5Na4yKcghfqv3GENVQ6J3/E2DG7rsElwi5qCUeJI/lcYZC2D TTNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tl3rjpPzWvGvL5lEB/U94s6R20w0vWjGnxBhIo2dvKk=; b=aFaXkjX9/NLqwrC/IhUugqgV9jtX0Dl3V8eq3IGGo4phD3y6X59SFYhj45BDl0hvW+ /da2IU9ajo7vmjdu6FV2J+0GNGsNVWwoTd0YIsrVlryCD9ll3cElNA7jC+GkxpQGd1jH 5It4DKdV/Zb2gJt7NbDexhnwO+6s61e6Swbe5bLf/kj04xP2EXm9fT0kZZi8Wqfvp4XK IIVSZn0TfNQpw9Hf6JNCrvb7BCN1U5H/myHmfZPC6cNCE87k7PUGYig7ywZ81HTHcC6N sDdquuIUDJMsbWTVA+ewwchdO7DSe1dK+0PYDHD0qG5HTGF/cJ5sRUE9hSFFDd92L41k MUKQ== X-Gm-Message-State: AGi0PuZcQfTQIf9BvZRvQxq8GkxrtqPZ9dDlI+rPfOD7HZXnn/XiZfna 1ccl09Pit4ACdCJZsJljy+4= X-Google-Smtp-Source: APiQypJ5Bd4cb55PnwIBXPCIWT2apA4KPXv3BEMMC4L//z/T8pBCdKHDTlpqBVA2XnPhAUyRblNVNg== X-Received: by 2002:a2e:8316:: with SMTP id a22mr8266776ljh.70.1586027413292; Sat, 04 Apr 2020 12:10:13 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id p2sm3419402lfh.85.2020.04.04.12.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2020 12:10:12 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 4 Apr 2020 21:10:10 +0200 To: "Paul E. McKenney" Cc: "Uladzislau Rezki (Sony)" , LKML , Joel Fernandes , RCU , linux-mm@kvack.org, Andrew Morton , Steven Rostedt , Oleksiy Avramchenko Subject: Re: [PATCH 1/1] rcu/tree: add emergency pool for headless case Message-ID: <20200404191010.GD424@pc636> References: <20200403173051.4081-1-urezki@gmail.com> <20200403191419.GU19865@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200403191419.GU19865@paulmck-ThinkPad-P72> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 03, 2020 at 12:14:19PM -0700, Paul E. McKenney wrote: > On Fri, Apr 03, 2020 at 07:30:51PM +0200, Uladzislau Rezki (Sony) wrote: > > Maintain an emergency pool for each CPU with some > > extra objects. There is read-only sysfs attribute, > > the name is "rcu_nr_emergency_objs". It reflects > > the size of the pool. As for now the default value > > is 3. > > > > The pool is populated when low memory condition is > > detected. Please note it is only for headless case > > it means when the regular SLAB is not able to serve > > any request, the pool is used. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > kernel/rcu/tree.c | 133 +++++++++++++++++++++++++++++++++------------- > > 1 file changed, 97 insertions(+), 36 deletions(-) > > > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > > index 5e26145e9ead..f9f1f935ab0b 100644 > > --- a/kernel/rcu/tree.c > > +++ b/kernel/rcu/tree.c > > @@ -114,6 +114,14 @@ int rcu_num_lvls __read_mostly = RCU_NUM_LVLS; > > int rcu_kfree_nowarn; > > module_param(rcu_kfree_nowarn, int, 0444); > > > > +/* > > + * For headless variant. Under memory pressure an > > + * emergency pool can be used if the regular SLAB > > + * is not able to serve some memory for us. > > + */ > > +int rcu_nr_emergency_objs = 3; > > +module_param(rcu_nr_emergency_objs, int, 0444); > > Please document this in Documentation/admin-guide/kernel-parameters.txt. > Will do that, Paul! Thanks for good point :) -- Vlad Rezki