From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE01C43331 for ; Fri, 3 Apr 2020 14:36:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B6062073B for ; Fri, 3 Apr 2020 14:36:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Hf1KZ1qQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B6062073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 61CAD8E0008; Fri, 3 Apr 2020 10:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CE008E0007; Fri, 3 Apr 2020 10:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B118E0008; Fri, 3 Apr 2020 10:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0123.hostedemail.com [216.40.44.123]) by kanga.kvack.org (Postfix) with ESMTP id 3A91F8E0007 for ; Fri, 3 Apr 2020 10:36:03 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E9C0D4DBF for ; Fri, 3 Apr 2020 14:36:02 +0000 (UTC) X-FDA: 76666793364.04.baby11_51de99f933f27 X-HE-Tag: baby11_51de99f933f27 X-Filterd-Recvd-Size: 3943 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 14:36:02 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id v16so7189119ljg.5 for ; Fri, 03 Apr 2020 07:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zmPYYW3fxClIYaAQ3d5kwhebWv1mnQ+1ShHjdxdDtmU=; b=Hf1KZ1qQmdj/mjtE6P1FKY3Ud/bzbLAgQS3JOTKm2ISSGkHwg51cYv/VioKxVCzdQp faSw1d9n5ma/2y5jkAkLT9AM+nz5dJwa08TSRC3KmEl6tehcIshqDmgOu4EogubN1dJk /JDmM5l+j5eM+9wEeOQqAugI7/x38sVvEmhQ6XBZdKTSP6ywp2e4s+5nQeCL4CAfDdVt GO7eOfw+2WyrGTCC1kJdLSrvPAYoUXIMmrt9Je3F8+7XXG6sJUNz3cizBYC2Agu8Kh0e wDla8AziaQ2B1yRbT2cOBRXBceBm9b1WZdFh68d9lHbQ1OtQA2donIqzy1o5DLmnjyl8 cacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zmPYYW3fxClIYaAQ3d5kwhebWv1mnQ+1ShHjdxdDtmU=; b=VYkCPqfMG3Ftrvi6CCK0VD7sZE5N2Mj1TpXNX/ABEu0w3M8M2yZKWc6neaUS4Dxvmy WBl1Ph34rmGmoOcHWN9pgUM0nyNmt8YOAIgFJE2ZJW9xm62EBqnbVwRJkRON0Iqgwqe0 uLpBtCISkk/A7PifgBZ0aIAlEM3/xiJV+evginCRxMcxyoPNGlwZnmJqyi88IzCfs1Wu YF5Vy5TOer7+TeNYXCrqQyG3vAudQI8yQaUxrjmN9Yks4PHOVgMtpvaSRkDKBqYkmHF6 JOR1qC0yOrXJgzjjRgzPM/R9mq/3kZ5xjzaBekj6nAfQPMkQnrF9yNF89+k81K9mxskf Lzpw== X-Gm-Message-State: AGi0PuYQyVRmpAclxtBnKTm2hrigZUBP6VHtQxUJ0WnYV2/T801k+W/2 ZNA6FmwxVaD4eAyvalKw4asiiA== X-Google-Smtp-Source: APiQypIMtF298Yl8bns41YZvM//TAVUblf05xp8RS423ZldCdYW94Ak2bpOVE3gTdd9ciXzdKrrYAw== X-Received: by 2002:a2e:6809:: with SMTP id c9mr4915106lja.251.1585924561034; Fri, 03 Apr 2020 07:36:01 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id p5sm5923335ljn.99.2020.04.03.07.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 07:36:00 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 94A6D10132D; Fri, 3 Apr 2020 17:35:59 +0300 (+03) Date: Fri, 3 Apr 2020 17:35:59 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: kirill.shutemov@linux.intel.com, hughd@google.com, aarcange@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: thp: don't need drain lru cache when splitting and mlocking THP Message-ID: <20200403143559.aex2w7utvkf5rr5y@box> References: <1585337380-97368-1-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1585337380-97368-1-git-send-email-yang.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Mar 28, 2020 at 03:29:40AM +0800, Yang Shi wrote: > Since the commit 8f182270dfec ("mm/swap.c: flush lru pvecs on compound > page arrival") THP would not stay in pagevec anymore. So the > optimization made by commit d965432234db ("thp: increase > split_huge_page() success rate") doesn't make sense anymore, which tries > to unpin munlocked THPs from pagevec by draining pagevec. > > And draining lru cache before isolating THP in mlock path is unnecessary > either. > > Cc: Kirill A. Shutemov > Cc: Hugh Dickins > Cc: Andrea Arcangeli > Signed-off-by: Yang Shi Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov