From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F101C2BA12 for ; Fri, 3 Apr 2020 13:32:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03850206B8 for ; Fri, 3 Apr 2020 13:32:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="V9OaIG26" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03850206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D7B88E0008; Fri, 3 Apr 2020 09:32:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5881F8E0007; Fri, 3 Apr 2020 09:32:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49DF08E0008; Fri, 3 Apr 2020 09:32:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 2F6928E0007 for ; Fri, 3 Apr 2020 09:32:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D4C625DF0 for ; Fri, 3 Apr 2020 13:32:55 +0000 (UTC) X-FDA: 76666634310.03.corn93_70d990bafe54c X-HE-Tag: corn93_70d990bafe54c X-Filterd-Recvd-Size: 4734 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Apr 2020 13:32:55 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id i20so6936576ljn.6 for ; Fri, 03 Apr 2020 06:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1B9NLeMDtTnr4dZAofQWYRGmeVDWcEa7QUbOLt8Zif0=; b=V9OaIG26ZZXBs2ja92clufhFn4bOl7BZKyyKBPjIS97kJICoeFTJ/gNh0JRjSkG8XM sELHUQIHzUNHOUZ1KDMD/J+JEE+vaUJpNarNzd+T8/0ftnB72UpO4ubBpiHPXj/zfB/H qSb3zG1ktIjiC5q7Fdq8Qpf+r7s1gTZ76sQZ/8I9hP0pHwprXb16FgqdXMOUJzZYq8+m ItiVGlE5Rswak81VqO7oL4nCyx0sPtR8LrcNBqEU1YCGzZUuzifVW9lZr3AL+487jotX MmK7sbjRL0Ey5HtpevAa+FI9mrXKmMspJxdLSoKnl7MKovjcPchWGV9RwTc6OsmH+M8P 8STg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1B9NLeMDtTnr4dZAofQWYRGmeVDWcEa7QUbOLt8Zif0=; b=p8/pi0XzmKNBxR2ujGmeT62kBlm7o0jSMlhTnJPwnwEDm2T73g12lQfH8nQc4C3j64 YzbfN7jvv59p+gK2Ls6MMi2yb3s/4mM+sOtnp/UpskB3M2LntxKu4tTnpWhVgUEpk5I9 F37i9X6xZVPe2X+Y6DgKubDJg6sGlQj1C7wQUfkexWN0EUtuNMgEV1VCATHx1RZFET7M AHCOwdESopQ8gP/yulFmFz01v3Wg/fzvmm7pT7f2xf3tBs8aJtuNS2lQxu5lmEVcc1ci MchaREdsNRIlkp+jic/eDZHLXqEHR4VV4VZckxRYthd4PI3Dh2VdxzHRMA63NZrSGss0 8UzA== X-Gm-Message-State: AGi0PuaX6sQTA+EGuAWgOlZszj8U/itpsh3YVEiQBC09CDinFJYMjh2E 8UkAaiTj2N3zOJSBpdqpl0XQFA== X-Google-Smtp-Source: APiQypJoMxosZHh+k2+LEa98vRpsbBdcqv2X4B9kWQ22u0lddJXax1ykbJNUZYV1LR2PHYfc5evJKQ== X-Received: by 2002:a2e:95c4:: with SMTP id y4mr4912219ljh.94.1585920773859; Fri, 03 Apr 2020 06:32:53 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id d12sm5748186lfi.86.2020.04.03.06.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 06:32:53 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id AB1DD100F13; Fri, 3 Apr 2020 16:32:52 +0300 (+03) Date: Fri, 3 Apr 2020 16:32:52 +0300 From: "Kirill A. Shutemov" To: Naresh Kamboju Cc: Andrew Morton , linux- stable , linux-mm , "Joel Fernandes (Google)" , William Kucharski , Julia Lawall , Michal Hocko , Will Deacon , Greg Kroah-Hartman , lkft-triage@lists.linaro.org, Mike Kravetz , LTP List Subject: Re: mm/mremap.c : WARNING: at mm/mremap.c:211 move_page_tables+0x5b0/0x5d0 Message-ID: <20200403133252.ivdqoppxhc6w5b47@box> References: <20200402133849.mmkvekzx37kw4nsj@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 03, 2020 at 12:56:57AM +0530, Naresh Kamboju wrote: > [ 734.876355] old_addr: 0xbfe00000, new_addr: 0xbfc00000, old_end: 0xc0000000 The ranges are overlapping. We don't expect it. mremap(2) never does this. shift_arg_pages() only moves range downwards. It should be safe. Could you try this: diff --git a/mm/mremap.c b/mm/mremap.c index af363063ea23..ddd5337de395 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -205,10 +205,14 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr, return false; /* - * The destination pmd shouldn't be established, free_pgtables() - * should have release it. + * mremap(2) clears the new place, so the new_pmd is expected to be + * clear. + * + * But move_page_tables() is also called from shift_arg_pages() that + * allows for overlapping address ranges. The shift_arg_pages() case + * is also safe as we only move page tables downwards. */ - if (WARN_ON(!pmd_none(*new_pmd))) + if (WARN_ON(!pmd_none(*new_pmd) && old_addr > new_addr)) return false; /* -- Kirill A. Shutemov